-
Bug
-
Resolution: Fixed
-
Major
-
2.6.4, 2.7.1
-
MOODLE_26_STABLE, MOODLE_27_STABLE
-
MOODLE_26_STABLE, MOODLE_27_STABLE
-
master_
MDL-46639 -
There seems to be a serious bug in the SCORM External AICC code which means you can't connect to external SCORM courses from the latest versions of Moodle 2.6 and 2.7 (at time of writing this is 2.6.4 and 2.7.1).
I believe the errors are in /mod/scorm/module.js and /mod/scorm/locallib.php
In module.js, line approx 746...
if (tree.rootNode.children[0].title !== scoes_nav[launch_sco].url) {
|
var node = tree.getNodeByAttribute('title', scoes_nav[launch_sco].url);
|
if (node !== null) {
|
scorm_first_url = node;
|
}
|
} else {
|
scorm_first_url = tree.rootNode.children[0];
|
}
|
… should be…
if (tree.rootNode.children.length > 0) {
|
if (tree.rootNode.children[0].title !== scoes_nav[launch_sco].url) {
|
var node = tree.getNodeByAttribute('title', scoes_nav[launch_sco].url);
|
if (node !== null) {
|
scorm_first_url = node;
|
}
|
} else {
|
scorm_first_url = tree.rootNode.children[0];
|
}
|
}
|
In locallib.php approx line 304-ish...
} else if ($scorm->scormtype === SCORM_TYPE_AICCURL and $cfg_scorm->allowtypeexternalaicc) {
|
require_once("$CFG->dirroot/mod/scorm/datamodels/aicclib.php");
|
// AICC
|
if (!scorm_parse_aicc($scorm)) {
|
$scorm->version = 'ERROR';
|
}
|
$scorm->version = 'AICC';
|
… should, I think, look like…
} else if ($scorm->scormtype === SCORM_TYPE_AICCURL and $cfg_scorm->allowtypeexternalaicc) {
|
require_once("$CFG->dirroot/mod/scorm/datamodels/aicclib.php");
|
// AICC
|
$result = scorm_parse_aicc($scorm);
|
if (!$result) {
|
$scorm->version = 'ERROR';
|
} else {
|
$scorm->launch = $result;
|
}
|
$scorm->version = 'AICC';
|
Please do let me know if there is any more information you need.
- has a QA test
-
MDLQA-8720
A teacher can add a SCORM External AICC type package to a course
-
- Open
-
-
MDLQA-15261
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-15850
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-16496
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-17113
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-17703
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-18208
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-18702
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-19166
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
-
MDLQA-20056
CLONE - A teacher can add a SCORM External AICC type package to a course
-
- Passed
-
- will help resolve
-
-
- Closed
-