Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46658

Prepare and integrate grader code from UCLA

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      Preparation
      1. Create a Medium course, and an XS course
      2. View the gradebook for each
      Instructions

      Sorry - there's no behat for this and I don't think it's possible for behat to work with it sadly.
      In a variety of browsers, and using at least the bootstrapbase, and base themes, and using RTL:

      1. Move around the gradebook and confirm:
        • that you can always see the row header and columns
        • that the columns and grades line up with the correct user and activity
        • that floating headers appear at the 'correct' times:
          • The left headers should be visible all time time
          • The footer should always be available if it is present
          • The header should always be visible
          • The various left headers (Overall Average, Controls, and Range if enabled) are always visible
      2. Turn editing on
        • Reconfirm
      3. Turn editing off
      4. Edit the preferences, and enable AJAX editing
      5. Scroll into the middle of the course to ensure that all of the floating headers are visible and floating
      6. Click into a cell
        • Confirm that the cell is replaced with an input field
        • Confirm that the floating column header resized to fit the new width
      7. Inspect the input field and add some more height to the class - e.g.

        .gradeparent .text {
          height: 50px;
        }
        

      8. Click into another field
        • Confirm that the input field is nice and large again
        • Confirm that the height of the floating username cell was updated too

      Notes:

      • IE sucks at tables, regardless of these changes. Even with no Javascript enabled at all, it sucks.
      • Generally speaking tablet devices only emit one scroll event - at the end of the touch.
      Show
      Preparation Create a Medium course, and an XS course View the gradebook for each Instructions Sorry - there's no behat for this and I don't think it's possible for behat to work with it sadly. In a variety of browsers, and using at least the bootstrapbase, and base themes, and using RTL: Move around the gradebook and confirm: that you can always see the row header and columns that the columns and grades line up with the correct user and activity that floating headers appear at the 'correct' times : The left headers should be visible all time time The footer should always be available if it is present The header should always be visible The various left headers (Overall Average, Controls, and Range if enabled) are always visible Turn editing on Reconfirm Turn editing off Edit the preferences, and enable AJAX editing Scroll into the middle of the course to ensure that all of the floating headers are visible and floating Click into a cell Confirm that the cell is replaced with an input field Confirm that the floating column header resized to fit the new width Inspect the input field and add some more height to the class - e.g. .gradeparent .text { height: 50px; } Click into another field Confirm that the input field is nice and large again Confirm that the height of the floating username cell was updated too Notes: IE sucks at tables, regardless of these changes. Even with no Javascript enabled at all, it sucks. Generally speaking tablet devices only emit one scroll event - at the end of the touch.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-46658-master
    • Story Points:
      195
    • Sprint:
      FRONTEND Sprint 14

      Description

      UCLA have submitted some code for an updated view of the gradebook and it looks that we may accept this into core.

      It still needs a little bit of work as part of this issue including:

      • Merge existing commits where relevant
      • Update to meet coding style guidelines (Primarily JS)
      • Move hardcoded styles to css
      • Check SASS and produce a definitive CSS/Less set (as appropriate) and remove SASS files again

      There may be more...

        Attachments

          Issue Links

          1.
          Bring in code from UCLA Sub-task Closed Andrew Nicols
          2.
          Update code from UCLA to meet coding style guidelines Sub-task Closed Andrew Nicols
          3.
          Re-organised CSS of the grader report Sub-task Closed Frédéric Massart
          4.
          Handle floating objects with RTL languages Sub-task Closed Frédéric Massart
          5.
          Make the grader report work on theme_base and derivatives Sub-task Closed Frédéric Massart
          6.
          Fix RTL styling of the new grader report Sub-task Closed Frédéric Massart
          7.
          Fix highlighting behaviour in the new grader report Sub-task Closed Frédéric Massart
          8.
          Styling for the grader report when editing is turned on Sub-task Closed Frédéric Massart
          9.
          Migrate row/column highlight code to YUI module Sub-task Closed Andrew Nicols
          10.
          Remove old functionality Sub-task Closed Andrew Nicols
          11.
          Move grader tooltip code to YUI module Sub-task Closed Andrew Nicols
          12.
          The tooltip prevents the user from entering the feedback field Sub-task Closed Frédéric Massart
          13.
          Add floating title for the footer Sub-task Closed Andrew Nicols
          14.
          Classes .overridden and .ajaxoverridden are not changing the styles Sub-task Closed Frédéric Massart
          15.
          Fill the gap in the floating columns when "controls" are available Sub-task Closed Andrew Nicols
          16.
          Restore AJAX editing Sub-task Closed Zachary Durber
          17.
          Update table row/column sizes when AJAX quick editing Sub-task Closed Andrew Nicols
          18.
          Change category total header Sub-task Closed Andrew Nicols
          19.
          Add authentic data to Grade report prototype Sub-task Closed Unassigned
          20.
          Test the Grader report on a number of third-party themes Sub-task Closed Dave Cooper
          21.
          Investigate use of throttle on handle event handlers Sub-task Closed Andrew Nicols
          22.
          Check issues with left/right when all blocks docked Sub-task Closed Andrew Nicols

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14