[MDL-46682] External DB auth: IN sql clause can get too big - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
git://github.com/abgreeve/moodle.git
Pull Master Branch:
wip-~~MDL-46682~~-master
Pull Master Diff URL:
https://github.com/abgreeve/moodle/compare/ac8d6cf...wip-MDL-46682-master
Testing Instructions:
Hide

Enable external DB authentication plugin

Set up the plugin on an external site containing more than 70.000 users (use the data generator in the Admin > Development > Generate course - you may want to edit the generator php script to allow the creation of 70.000 users instead of the default)

Set "Removed ext user" to "suspended" and in the field mapping section, 'update local' to 'on every login'. These two options should force the sync_users.php script to go through remove/update users (to be verified though)

Run the aut/db/cli/sync_users.php
Show
Enable external DB authentication plugin Set up the plugin on an external site containing more than 70.000 users (use the data generator in the Admin > Development > Generate course - you may want to edit the generator php script to allow the creation of 70.000 users instead of the default) Set "Removed ext user" to "suspended" and in the field mapping section, 'update local' to 'on every login'. These two options should force the sync_users.php script to go through remove/update users (to be verified though) Run the aut/db/cli/sync_users.php

In auth/db/auth.php - sync_users()

If your sync operation allows to remove/update users, and if the number of user of the external db is above 65535, then the sync crashes.

Error: number of parameters must be between 0 and 65535

caused a regression

MDL-57193 External DB Auth: Suspends or Deleted Every User Bug

has a non-specific relationship to

MDL-27071 Oracle cannot cope withan IN operator with more than 1000 conditions in it

MDL-15196 external db authentication compares user names case-sensitive

has been marked as being related by

MDL-58847 Synchronization script (enrol/ldap/lib.php) have problems with the courses that have a lot of users to sync (more than 1000)

Participants:: Adrian Greeve, Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Jérôme Mouneyrac, John Okely, Marina Glancy, Murilo Timo, Murilo Timo, Rajesh Taneja

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo