[MDL-46692] defaultpreference_trackforums setting implemented incorrectly - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.8
Fix Version/s: 2.8
Component/s: Forum
Labels:
- Totara
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
https://github.com/skodak/moodle.git
Pull Main Branch:
wip_~~MDL-46692~~_m28_forum
Pull Main Diff URL:
https://github.com/skodak/moodle/compare/master...wip_MDL-46692_m28_forum
Testing Instructions:

Hide

install moodle and verify there are no bogus setting on the page where you set site title and description

Show
install moodle and verify there are no bogus setting on the page where you set site title and description

Description

the problem is that admin settings must not be enclosed by ifs depending on other settings:

if (!empty($CFG->forum_trackreadposts)) {

because the defaults do not get applied during install and upgrade

Attachments

Issue Links

is a regression caused by

MDL-37812 admin can set site-wide default settings for user profile fields: Email display, format, digest, Forum subscription & tracking, use HTML editor, Screen reader

Closed

Activity

People

Assignee:: Petr Skoda

Reporter:: Petr Skoda

Integrator:: Marina Glancy

Tester:: Andrew Davis

Participants:: Andrew Davis, CiBoT, Marina Glancy, Petr Skoda, Zachary Durber

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 06/Aug/14 1:01 PM

Updated:: 15/Aug/14 1:18 AM

Resolved:: 15/Aug/14 1:18 AM

Fix Release Date:: 10/Nov/14