[MDL-46754] clean_param with PARAM_TEXT does not support less than character - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Workaround:

Hide

In circumstances where less than symbols are required, use PARAM_RAW instead.

Show
In circumstances where less than symbols are required, use PARAM_RAW instead.
Testing Instructions:
Hide

Using the test branch: https://github.com/gjb2048/moodle/tree/master_MDL-46754_test which adds this code: https://github.com/gjb2048/moodle/compare/master_MDL-46754_test

Create a new topic format based course and enter the course.

Observe that the output should be:

clean_param('<',PARAM_TEXT): <
clean_param('>',PARAM_TEXT): >
clean_param('<',PARAM_RAW) : <
clean_param('>',PARAM_RAW) : >
Show
Using the test branch: https://github.com/gjb2048/moodle/tree/master_MDL-46754_test which adds this code: https://github.com/gjb2048/moodle/compare/master_MDL-46754_test Create a new topic format based course and enter the course. Observe that the output should be: clean_param('<',PARAM_TEXT): < clean_param('>',PARAM_TEXT): > clean_param('<',PARAM_RAW) : < clean_param('>',PARAM_RAW) : >

In moodlelib.php, the comment for PARAM_TEXT states:

/**

 * PARAM_TEXT - general plain text compatible with multilang filter, no other html tags. Please note '<', or '>' are allowed here.

*/

define('PARAM_TEXT',  'text');

When calling 'clean_param' with text containing a less than character then no text is returned. To reproduce, with the code:

echo '<h3>clean_param(\'<\',PARAM_TEXT): '.clean_param('<',PARAM_TEXT).'</h3>';

echo '<h3>clean_param(\'>\',PARAM_TEXT): '.clean_param('>',PARAM_TEXT).'</h3>';

echo '<h3>clean_param(\'<\',PARAM_RAW) : '.clean_param('<',PARAM_RAW).'</h3>';

echo '<h3>clean_param(\'>\',PARAM_RAW) : '.clean_param('>',PARAM_RAW).'</h3>';

the output is:

clean_param('<',PARAM_TEXT):

clean_param('>',PARAM_TEXT): >

clean_param('<',PARAM_RAW) : <

clean_param('>',PARAM_RAW) : >

when it should be:

clean_param('<',PARAM_TEXT): <

clean_param('>',PARAM_TEXT): >

clean_param('<',PARAM_RAW) : <

clean_param('>',PARAM_RAW) : >

caused a regression

CONTRIB-5211 Section 5 does not remain expanded when browsing away and back

Discovered while testing

CONTRIB-5211 Section 5 does not remain expanded when browsing away and back

duplicates

MDL-49071 Question type Match , does not work with "<" as a answer

has been marked as being related by

MDL-29370 Cannot create a forum post with subject "x <> X"

is duplicated by

MDL-49077 clean_param($x, PARAM_TEXT) does not work the way users expect regarding < characters

MDL-74950 Text is truncated when saved if a < is immediatly followed by (an)other character(s), and not by a space

(1 is duplicated by)

Participants:: Gareth J Barnard, Marina Glancy, Michael de Raadt, Petr Skoda, Tim Hunt

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)