Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 3.5.4, 3.6.2
Affects Version/s: 2.6.4, 2.7.1, 3.4.5, 3.5.2, 3.6.1
Component/s: Roles / Access
Labels:
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
https://github.com/timhunt/moodle
Pull Main Branch:
~~MDL-46783~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-46783
Testing Instructions:
Hide

Go to 'Permissions' in the settings for any activity.

Verify that the capabilities moodle/site:accessallgroups, moodle/site:viewfullnames, moodle/site:trustconten and moodle/site:viewuseridentity are all listed there.

Check Permissions in the course settings.

Verify that those four capabilities appear alongside all the rest.
Show
Go to 'Permissions' in the settings for any activity. Verify that the capabilities moodle/site:accessallgroups, moodle/site:viewfullnames, moodle/site:trustconten and moodle/site:viewuseridentity are all listed there. Check Permissions in the course settings. Verify that those four capabilities appear alongside all the rest.

Description

To reproduce.

Go to any quiz (to pick just one relevant example).
Do Administration -> Check permissions for any user.

Expected result: moodle/site:viewuseridentity capability is listed, because it affects what can be seen in the quiz reports, or log report.

Actual result: permisisons for that capability is not shown.

Because this affects the logs report, it is relevant to all contexts, so it probably needs to be fixed in context_module::get_capabilities. I guess all the context_XXX classes should be reviewed at the same time.

The following capabilities should similarly be overridable in activity contexts:

moodle/site:accessallgroups
moodle/site:viewfullnames
moodle/site:trustcontent

Having just worked on ~~MDL-63818~~ and ~~MDL-63772~~, I now see that the right fix is to just change the capability definition to say 'contextlevel' => CONTEXT_MODULE, for these caps, then they will show up when overriding permissions in system, course cat, course or module contexts.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-46783.PNG
150 kB
06/Dec/18 11:18 AM

Issue Links

has a non-specific relationship to

MDL-63818 It should be possible to override Repository capabilties in activity contexts

Closed

MDL-63772 There should be a capability to control use of the Atto Record RTC button

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Jason Platts

Integrator:: Jake Dallimore

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, David Monllaó, Eloy Lafuente (stronk7), Jake Dallimore, Jason Platts, Marina Glancy, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 13/Aug/14 4:55 AM

Updated:: 10/Dec/18 8:25 PM

Resolved:: 10/Dec/18 8:46 AM

Fix Release Date:: 14/Jan/19

Time Tracking

Estimated:

Remaining:

Logged:

30m