[MDL-46803] Course reset unenrols users from all their roles - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.6.4, 3.4.5, 3.5.2, 3.5.5, 3.6, 3.7
Fix Version/s: 3.5.6, 3.6.4
Component/s: Course, Enrolments, Roles / Access
Labels:
- api_change
- ci
- patch
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
https://github.com/DSI-Universite-Rennes2/moodle.git
Pull Master Branch:
~~MDL-46803~~-greedy-roles-reset2
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...DSI-Universite-Rennes2:MDL-46803-greedy-roles-reset2
Testing Instructions:
Hide

test environment

enrol a user in a course with two different roles (e.g: student and teacher)

test scenario

Reset the course (Course administration > Reset) - Roles. Select only the student role. Click the "Reset course" button.

Go to the participants page (Navigation block / navigation drawer)

Check that our user is still enroled in course with the teacher role.

Give the user the student role again. Click the icon next to the Role for the user.

Reset the course (Course administration > Reset) - Roles. Select only the teacher role. Click the "Reset course" button.

Go to the participants page (Navigation block / navigation drawer)

Check that our user is still enroled in course with the student role

Give the user the teacher role again. Click the icon next to the Role for the user.

Reset the course (Course administration > Reset) - Roles. Select only the manager role. Click the "Reset course" button.

Go to the participants page (Navigation block / navigation drawer)

Check that our user is still enroled in course with the student role and teacher role

Reset the course (Course administration > Reset) - Roles. Select the teacher and student role. Click the "Reset course" button.

Go to the participants page (Navigation block / navigation drawer)

Check that the user has now be unenroled from the course.
Show
test environment enrol a user in a course with two different roles (e.g: student and teacher) test scenario Reset the course (Course administration > Reset) - Roles. Select only the student role. Click the "Reset course" button. Go to the participants page (Navigation block / navigation drawer) Check that our user is still enroled in course with the teacher role. Give the user the student role again. Click the icon next to the Role for the user. Reset the course (Course administration > Reset) - Roles. Select only the teacher role. Click the "Reset course" button. Go to the participants page (Navigation block / navigation drawer) Check that our user is still enroled in course with the student role Give the user the teacher role again. Click the icon next to the Role for the user. Reset the course (Course administration > Reset) - Roles. Select only the manager role. Click the "Reset course" button. Go to the participants page (Navigation block / navigation drawer) Check that our user is still enroled in course with the student role and teacher role Reset the course (Course administration > Reset) - Roles. Select the teacher and student role. Click the "Reset course" button. Go to the participants page (Navigation block / navigation drawer) Check that the user has now be unenroled from the course.

Description

Steps to reproduce:

In a course, go to Users > Enrolled users
Enrol user1 with Teacher role
Enrol user2 with Teacher and Student role
In course administration, go to Reset
In Reset course screen under Roles, select Unenrol users: Student
click on "Reset course"
back in Users > Enrolled users, notice how user2 has vanished.

Course reset obviously unenrols users matching the role chosen in the Reset course screen from all roles in the course.
This is problematic with users having more than one role.
We have seen cases of teachers locking themselves out of their own course after doing a course reset. It turned out they were enrolled with both Teacher and Student role.
It would perhaps be more intuitive to remove only the selected role but leave the enrolment and other roles intact if there are any.

In the database, unenrol users removes all role assignments for matching users from table mdl_role_assignments and deletes the row from table mdl_user_enrolments.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-46803.jpg
42 kB
21/Mar/19 1:51 PM
MDL-46803.patch
2 kB
06/Sep/14 5:24 PM

Issue Links

has been marked as being related by

MDL-51152 enrol_manual_unenrol_users ignore roleid parameter

Development in progress

is duplicated by

MDL-49751 Cleanup removes too many users

Closed

Activity

People

Assignee:: Julien Boulen

Reporter:: Heiko Schach

Peer reviewer:: Amaia Anabitarte

Integrator:: Adrian Greeve

Tester:: Anna Carissa Sadia

Participants:: Adrian Greeve, Amaia Anabitarte, Anna Carissa Sadia, Ben Dubuisson, CiBoT, Dominique, Heiko Schach, Julien Boulen, Marina Glancy, Sara Arjona (@sarjona)

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)

Votes:: 2 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 14/Aug/14 4:39 AM

Updated:: 07/May/19 1:51 PM

Resolved:: 22/Mar/19 6:48 AM

Fix Release Date:: 13/May/19

Time Tracking

Estimated:

Remaining:

Logged: