Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46814

Export Calendar does not use the form API

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1, 2.8.1, 2.9
    • Fix Version/s: 2.9
    • Component/s: Accessibility, Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a few events
      2. Go to Site Pages > Calendar
      3. Click the "Export Events" button
      4. Confirm the functionality of the form works as it previously did:
      • Confirm that radio selections are required
      • Confirm that the URL works and gets the events expected
      • Confirm that the export button downloads a file with the events in it
      Show
      Create a few events Go to Site Pages > Calendar Click the "Export Events" button Confirm the functionality of the form works as it previously did: Confirm that radio selections are required Confirm that the URL works and gets the events expected Confirm that the export button downloads a file with the events in it
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m28_MDL-46814

      Description

      If you go to export a calendar (via Site Pages > Calendar and then clicking the export button), the resulting form is not created using the Moodle form API. Instead it is manually creating the form within the renderer function (it also appears that there are some other HTML forms being created there as well).

      This was detected in a recent accessibility report as the feildset tag was outside the form tag (which in itself looks like an easy fix, but it would be better to move the entire form in to the Moodle form API)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              brianb Brian Barnes
              Reporter:
              brianb Brian Barnes
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Dan Poltawski
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15