Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46816

plagiarism function call not needed.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This code isn't used anywhere - it sets an $output var but it never used in code.
      I suppose we should make sure behat and unit tests pass - not sure if any other extra testing needs to be done.

      Show
      This code isn't used anywhere - it sets an $output var but it never used in code. I suppose we should make sure behat and unit tests pass - not sure if any other extra testing needs to be done.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      master_MDL-46816

      Description

      in renderable assign_files::construct__ it makes a call to plagiarism functions to set $output but $output is never actually used. It's not needed here in the construct function as it's used properly elsewhere like in htmllize_tree

        Attachments

          Activity

            People

            Assignee:
            danmarsden Dan Marsden
            Reporter:
            danmarsden Dan Marsden
            Peer reviewer:
            Andrew Nicols
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Sep/14