[MDL-46853] Import calendar event without DTEND incorrectly assumes 1 hour duration - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.6.4, 2.7.1
Fix Version/s: 2.6.6, 2.7.3
Component/s: Calendar
Labels:
- patch
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
https://github.com/gdharris/moodle
Pull Main Branch:
patch-1
Pull Main Diff URL:
https://github.com/gdharris/moodle/compare/master...patch-1
Testing Instructions:
1. Create No Duration Event
2. Export it
3. Import it as ICS
4. The imported event should have no duration

Description

When importing an ICS file that was exported from the Moodle calendar, events with no duration are changed to have a 1 hour duration because they have no DTEND property.

The following condition is in calendar/lib.php:

if (empty($event->properties['DTEND'])) {

    $eventrecord->timeduration = 3600; // one hour if no end time specified

} else {

    $eventrecord->timeduration = strtotime($event->properties['DTEND'][0]->value) - $eventrecord->timestart;

Attachments

Issue Links

has been marked as being related by

MDL-47571 add support for DURATION when importing iCalendar events

Closed

Activity

People

Assignee:: Unassigned

Reporter:: Gary Harris

Peer reviewer:: Damyon Wiese

Integrator:: Sam Hemelryk

Tester:: Mark Nelson

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, Gary Harris, Helen Foster, Jonathan Champ, Marina Glancy, Mark Nelson, Sam Hemelryk

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 16/Aug/14 11:24 AM

Updated:: 20/Feb/15 11:50 AM

Resolved:: 25/Oct/14 2:27 AM

Fix Release Date:: 10/Nov/14