Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46860

Filepicker breaks inside ManageFiles popup in Atto

    Details

    • Testing Instructions:
      Hide

      Versions

      This change has been applied to master, 29 and 28 so please test that it works on each version.

      Themes

      Please follow the testing instructions below on both the "clean" theme (or bootstrapbase) and the "base" theme. The changes to the file picker should work on both.

      Browsers

      Please follow the test on each of the themes on each of the major browsers to ensure compatibility.
      E.g. Chrome, Firefox, Safari etc.

      Testing Instructions

      Standard Screen

      1. Log in with a site admin that can create courses
      2. Create a new course
        • Administration block > site administration > manage courses and categories > Create new course
      3. Scroll to the "Description" section
      4. In the "course summary" click on the far right icon (paper with paperclip) "Manage files". This should pop up the manage files dialogue
      5. Click on the left icon (paper with a "+" sign) "Add...". This should pop up the filepicker dialogue.
      6. CHECK: The filepicker dialogue should fit within the manage files window
      7. CHECK: The filepicker dialogue should not be draggable
      8. CHECK: The filepicker should be standard styling (the nav list on the left and item block next to it on the right) not responsive (nav list on top with item block below it)
      9. Close those dialogue screens and return to the create course page
      10. In the "course summary files" part of the Description section, click on the left icon (paper with a "+"). This should open the filepicker dialogue on it's own, not within the manage files dialogue.
      11. CHECK: The dialogue should be 873px wide (as it was before these changes) which is slightly wider than the manage files dialogue.
      12. CHECK: The filepicker dialogue should be draggable
      13. CHECK: The filepicker dialogue should be in standard styling, not responsive.

      Responsive Screen (< 768px wide)

      1. CHECK: Repeat steps above to open the filepicker dialogue within the manage files window. This time the manage files dialogue should be full screen however the filepicker wont be. It makes it difficult to use (this is the issue I mentioned in my comment).
      2. CHECK: Open the filepicker dialogue directly (see above) and this should be fullscreen (as it was before my changes).
      Show
      Versions This change has been applied to master, 29 and 28 so please test that it works on each version. Themes Please follow the testing instructions below on both the "clean" theme (or bootstrapbase) and the "base" theme. The changes to the file picker should work on both. Browsers Please follow the test on each of the themes on each of the major browsers to ensure compatibility. E.g. Chrome, Firefox, Safari etc. Testing Instructions Standard Screen Log in with a site admin that can create courses Create a new course Administration block > site administration > manage courses and categories > Create new course Scroll to the "Description" section In the "course summary" click on the far right icon (paper with paperclip) "Manage files". This should pop up the manage files dialogue Click on the left icon (paper with a "+" sign) "Add...". This should pop up the filepicker dialogue. CHECK: The filepicker dialogue should fit within the manage files window CHECK: The filepicker dialogue should not be draggable CHECK: The filepicker should be standard styling (the nav list on the left and item block next to it on the right) not responsive (nav list on top with item block below it) Close those dialogue screens and return to the create course page In the "course summary files" part of the Description section, click on the left icon (paper with a "+"). This should open the filepicker dialogue on it's own, not within the manage files dialogue. CHECK: The dialogue should be 873px wide (as it was before these changes) which is slightly wider than the manage files dialogue. CHECK: The filepicker dialogue should be draggable CHECK: The filepicker dialogue should be in standard styling, not responsive. Responsive Screen (< 768px wide) CHECK: Repeat steps above to open the filepicker dialogue within the manage files window. This time the manage files dialogue should be full screen however the filepicker wont be. It makes it difficult to use (this is the issue I mentioned in my comment). CHECK: Open the filepicker dialogue directly (see above) and this should be fullscreen (as it was before my changes).
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-46860-master
    • Sprint:
      Team '; drop tables Sprint 9

      Description

      The left and the right side are separated by vertical separator usually.
      But the left panel with repositories has 100% width as the "potentially" right side with many elements. These elements don't have enough space and displayed at bottom.

      Steps to reproduce:
      1. Open "Manage files" window by clicking icon in text editor (e.g. "Add course" page)
      2. Click "Add..." in File manager.

        Gliffy Diagrams

          Attachments

          1. 1.png
            1.png
            43 kB
          2. 2.png
            2.png
            36 kB
          3. 3.PNG
            3.PNG
            47 kB
          4. filepicker_eng.png
            filepicker_eng.png
            40 kB
          5. filepicker_rus.png
            filepicker_rus.png
            40 kB

            Issue Links

              Activity

                People

                • Votes:
                  10 Vote for this issue
                  Watchers:
                  18 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Sep/15