Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46861

web service function core_grading_get_definitions has an invalid return value

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      The unit tests now include validation of the return value and so this can be tested by commenting out the areaname (line 104 in lib/classes/grading_external.php). The unit tests will fail.

      Line 104 should then be restored and the unit tests run again. The unit tests will now pass.

      Show
      The unit tests now include validation of the return value and so this can be tested by commenting out the areaname (line 104 in lib/classes/grading_external.php). The unit tests will fail. Line 104 should then be restored and the unit tests run again. The unit tests will now pass.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:

      Description

      The web service function core_grading_get_definitions returns an array of grading_areas and warnings.

      The structure of the grading_area array is defined in the function grading_area(). This defines the field areaname as a required field. However, this field is missing from the array that is created and returned in the function get_definitions().

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pcharsle Paul Charsley
              Reporter:
              pcharsle Paul Charsley
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Marina Glancy
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14