Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46887

Assignment file "Maximum submission size " set to "Activity upload limit" not enforced

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL46887_assignment_file_max_size
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. In plugins settings for assignment file submission specify the file size limit below the site limit
      2. Create a course with default upload limit
      3. Create an assignment with file submission
      4. As a student make sure that you have limit from #1 when submitting assignment
      5. Change the limit for a particular assignment
      6. As a student make sure that you have limit from #5 when submitting assignment
      7. Change the course limit to a value smaller than assignment limit
      8. As a student make sure that you have limit from #7 when submitting assignment
      Show
      In plugins settings for assignment file submission specify the file size limit below the site limit Create a course with default upload limit Create an assignment with file submission As a student make sure that you have limit from #1 when submitting assignment Change the limit for a particular assignment As a student make sure that you have limit from #5 when submitting assignment Change the course limit to a value smaller than assignment limit As a student make sure that you have limit from #7 when submitting assignment

      Description

      When setting an assignment's file "Maximum submission size " to use the "Activity upload limit" (assignsubmission_file | maxbytes), it is not enforced, with the "Site upload limit" being used instead.

      To reproduce

      1. Set assignsubmission_file | maxbytes to 20MB (or any value lower than the site upload limit, and substitute your value below).
      2. Create an assignment with "File submissions" enabled, leaving "Maximum submission size" as the "Activity upload limit (20MB)".
      3. View the assignment as a student, and view the "Add submission" form.

      Expected results

      • The "Maximum size for new files" is 20MB

      Actual results

      • The "Maximum size for new files" is the site limit (e.g. 100MB)

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38748 File upload submission file size

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-37122 Activities include course limit for files even when it exceedes the site limit

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              balchd Dave Balch
              Reporter:
              balchd Dave Balch
              Peer reviewer:
              Damyon Wiese Damyon Wiese
              Integrator:
              Marina Glancy Marina Glancy
              Tester:
              Andrew Davis Andrew Davis
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Sep/14