Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46907

Refactor user_button class to remove js methods

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: BACKEND
    • Component/s: Gradebook
    • Labels:
    • Story Points:
      20
    • Sprint:
      BACKEND Sprint 16

      Description

      As per the review on the parent epic the user_button class needs to be refactored as well -

      This user_button class is terrible. It just exposes methods to allow calling the js init functions it requires - but those functions are called from outside the class - ie the caller has to know all the functions and params that are required for the JS. Further - it builds up arrays of init functions and modules of which there is only one, and then calls them, in an inefficient way which prevents comboloading.

        Attachments

          Activity

            People

            Assignee:
            ankit_frenz Ankit Agarwal
            Reporter:
            ankit_frenz Ankit Agarwal
            Peer reviewer:
            Frédéric Massart
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: