Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46908

Bad typeof test in mod/scorm/module.js

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • 2.7.1
    • None
    • SCORM
    • MOODLE_27_STABLE

    Description

      On line 460 (https://github.com/moodle/moodle/blob/master/mod/scorm/module.js#L460), we have

      if (typeof result.nextactivity.id != undefined) {

      which always evaluates to true. It should be

      if (typeof result.nextactivity.id != 'undefined') {

      Attachments

        Issue Links

          is a regression caused by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-35418 Merge GSOC SCORM work

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              danmarsden Dan Marsden
              xiemaisi Max Schaefer
              Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: