Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46911

Unintended "jump" to first record when approving/unapproving an entry

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Enter a course as teacher
      • Create a database activity. In the settings, set "Entries -> Approval required" to "Yes". Create one text field. Create the default "List" and "Single" templates.
      • Enter 10 data records, with the text field consecutively set to "1", "2", "3" etc.
      • Click on "View list", set "Entries per page" to "3" and click "Save settings".
      • Navigate to page 2.
      • Click "Undo approval" (circle with diagonal bar) on the entry with text "5".
      • VERIFY: A message "Entry unapproved" is displayed. The screen is still a list on page 2, with entries 4,5,6 shown.
      • Click "Approve" (tickmark) on the entry with text "5".
      • VERIFY: A message "Entry approved" is displayed. The screen is still a list on page 2, with entries 4,5,6 shown.
      • Click on "View single". Navigate to page 5.
      • VERIFY: Entry with text "5" is shown.
      • Click "Undo approval" on the entry with text "5".
      • VERIFY: A message "Entry unapproved" is displayed. The screen is still showing only the entry with text "5", and the pagination bar is set to page 5.
      Show
      Enter a course as teacher Create a database activity. In the settings, set "Entries -> Approval required" to "Yes". Create one text field. Create the default "List" and "Single" templates. Enter 10 data records, with the text field consecutively set to "1", "2", "3" etc. Click on "View list", set "Entries per page" to "3" and click "Save settings". Navigate to page 2. Click "Undo approval" (circle with diagonal bar) on the entry with text "5". VERIFY: A message "Entry unapproved" is displayed. The screen is still a list on page 2, with entries 4,5,6 shown. Click "Approve" (tickmark) on the entry with text "5". VERIFY: A message "Entry approved" is displayed. The screen is still a list on page 2, with entries 4,5,6 shown. Click on "View single". Navigate to page 5. VERIFY: Entry with text "5" is shown. Click "Undo approval" on the entry with text "5". VERIFY: A message "Entry unapproved" is displayed. The screen is still showing only the entry with text "5", and the pagination bar is set to page 5.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:

      Description

      When a teacher browses a database in the "list" view, and clicks on the "approve" or "unapprove" button of one of the entries, then the next screen will always show the top of the list (first page, first entry), so that the recently approved entry is out of focus or not even present on the page. This is rather confusing for users.

      Expected behaviour: The list should include (and be focused on) the recently approved/unapproved entry.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Sep/14