Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46920

Data-target does nothing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.4, 2.7.1, 2.8
    • Fix Version/s: 2.6.6, 2.7.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      On Bootstrapbase:

      1. Log in.
      2. Observe that with a browser window wider than 979px, the content in the top right (top left on RTL) of the navbar is fully visible saying something to the effect that you are currently logged in.
      3. Narrow your window until the navbar collapses, showing the hamburger.
        • Inspect the hamburger HTML element and observe that it has a data-target attribute, consisting of a CSS3 selector.
      4. Click the hamburger and observe that it toggles the navbar contents.
      5. Modify the data-target attribute on the hamburger such that it points to the site brand, e.g. .brand
      6. Click the hamburger and observe that the class active is now being applied to the site brand.
      Show
      On Bootstrapbase: Log in. Observe that with a browser window wider than 979px, the content in the top right (top left on RTL) of the navbar is fully visible saying something to the effect that you are currently logged in. Narrow your window until the navbar collapses, showing the hamburger. Inspect the hamburger HTML element and observe that it has a data-target attribute, consisting of a CSS3 selector. Click the hamburger and observe that it toggles the navbar contents. Modify the data-target attribute on the hamburger such that it points to the site brand, e.g. .brand Click the hamburger and observe that the class active is now being applied to the site brand.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46920-master
    • Story Points:
      3
    • Sprint:
      FRONTEND Sprint 14

      Description

      Currently on themes based off bootstrap base have a button that expands the header and displays the users logged in status. This button has a data-target property which is meant to specify (or so I would think) what DOM elements are to be hidden or displayed at narrow screen resolutions

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jethac Jetha Chan
                Reporter:
                brianb Brian Barnes
                Peer reviewer:
                Andrew Nicols
                Integrator:
                Dan Poltawski
                Tester:
                Simey Lameze
                Participants:
                Component watchers:
                Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14