[MDL-46931] Duplicate get_records key column in users selector - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.6.4, 2.8.5, 3.1.3, 3.5.5, 3.6.3, 3.7
Fix Version/s: 3.5.6, 3.6.4
Component/s: Enrolments, Roles / Access
Labels:
- ci
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_28_STABLE, MOODLE_31_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-46931~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-46931
Testing Instructions:
Hide

Pre-requisites: To have "display errors" enabled and debugging level to DEBUG_DEVELOPER (both being admin settings)

Create a course

Enrol a user twice (for example manual and cohort, or self and manual enrolment methods)

From the Administration block, select Course Administration > Users > Permissions > Check Permissions

You should not get any debugging messages and should see each enrolled user once
Show
Pre-requisites: To have "display errors" enabled and debugging level to DEBUG_DEVELOPER (both being admin settings) Create a course Enrol a user twice (for example manual and cohort, or self and manual enrolment methods) From the Administration block, select Course Administration > Users > Permissions > Check Permissions You should not get any debugging messages and should see each enrolled user once

Description

To replicate:

Enrol same user in course via different enrolment methods. In this case, I had enrolled the user into the course via a cohort as a student and manually added them as a teacher.

From the Administration block, select 'Course Administration > Users > Permissions > Check Permissions'

The following debug message is displayed on screen:

Did you remember to make the first column something unique in your call to get_records? Duplicate value '5' found in column 'id'.

line 1005 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
line 121 of /admin/roles/classes/check_users_selector.php: call to mysqli_native_moodle_database->get_records_sql()
line 210 of /user/selector/lib.php: call to core_role_check_users_selector->find_users()
line 171 of /admin/roles/check.php: call to user_selector_base->display()

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-03-14-08-58-20-518.png
41 kB
14/Mar/19 8:58 AM

Issue Links

has been marked as being related by

MDL-22309 get_role_users() with more than one role assigned to user

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Jake Dallimore

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Janelle Barcega, Marina Glancy, Paul Holden

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 22/Aug/14 5:30 AM

Updated:: 15/Mar/19 11:25 AM

Resolved:: 15/Mar/19 11:25 AM

Fix Release Date:: 13/May/19

Time Tracking

Estimated:

Remaining:

Logged:

52m