Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: BACKEND
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      1. Able to enable AJAX editing.
      2. Works in editing and non-editing.
      3. Able to select Cells and edit them.
      4. Cells save on deselect or enter being pressed.
      5. Tab works on FF. (but causes error at final row)
      6. Arrow keys work, but not RTL auto-adjusted.

      Functionality should mimic what is available under stable for now.

      Show
      Able to enable AJAX editing. Works in editing and non-editing. Able to select Cells and edit them. Cells save on deselect or enter being pressed. Tab works on FF. (but causes error at final row) Arrow keys work, but not RTL auto-adjusted. Functionality should mimic what is available under stable for now.
    • Affected Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46936-master-3
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 14

      Description

      After the import of UCLA code, the AJAX editing has broken. In addition

      Todo

      • AJAX doesn't load at all. Missing id column so incorrect variables are supplied as arguments to module.js
      • Click to edit fields
      • Clicking on another element of the page should save
      • On blur (deselect) the change should save
      • Hitting escape should cancel - non edit mode
      • Arrow keys - Ctrl+Arrow Key fine on everything except Safari (and then it's just control+command+key)
      • Headings become misaligned when you edit an entry.
      • Analysis icon being forced to second line when editing cell

      Not handling

      • "Cannot read property 'setStyle' of null" error message - cannot reproduce
      • 'Error click this box to remove it' - error box is just text and not a box Occurs when invalid text is submitted to a cell
      • Javascript error - undefined is not a function (this._hideSpinner()) - will be handled in MDL-25544
      • Totals at the bottom aren't updated when you edit a cell. - will be handled in MDL-46658
      • Row not highlighted when you click in the name field - will be handled in MDL-46658, unrelated to AJAX editing
      • TAB'ing behaviour only works as desired on FF. (and even then it's not great, at the end of the column it tabs out) In IE, Safari and Chrome it tabs to elements outside of the table.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: