Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46946

user_not_fully_set_up() should force users to complete required custom user profile fields

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • MDL-46946-master-reqcusfield
    • Hide
      1. As an admin, define a required custom field.
      2. Make sure that users are redirected to the profile edit page to provide a value for required custom fields (same as for missing name or email).
      3. Make sure that if the required field is invisible or it is locked (and therefore can't be edited by the user), the user is not redirected to the profile page.

      Tips for extra tests:

      • If users are redirected to edit the profile and fill missing required custom fields, the filepicker / repositories should keep working on that page (applies to custom fields only).
      • In MNet environment, adding a custom profile field to the service provider site as required is not (has never been) supported. Users are expected to get an error that their profile is incomplete and are sent back to their identity provider site.
      Show
      As an admin, define a required custom field. Make sure that users are redirected to the profile edit page to provide a value for required custom fields (same as for missing name or email). Make sure that if the required field is invisible or it is locked (and therefore can't be edited by the user), the user is not redirected to the profile page. Tips for extra tests: If users are redirected to edit the profile and fill missing required custom fields, the filepicker / repositories should keep working on that page (applies to custom fields only). In MNet environment, adding a custom profile field to the service provider site as required is not (has never been) supported. Users are expected to get an error that their profile is incomplete and are sent back to their identity provider site.

    Description

      In /lib/moodlelib.php, the function user_not_fully_set_up() needs to be improved to check that required custom user profile fields have been completed.

      Currently users only need to complete their firstname, lastname and email fields in order to be considered 'fully set up'. The only way to ensure that required custom profile fields are completed is to modify core Moodle code, which is not ideal.

      There is a discussion on this issue at https://moodle.org/mod/forum/discuss.php?d=204052.

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57929 profile_has_required_custom_fields_set fails to detect if a custom profile field is empty

          • Minor - Minor loss of function where workaround is possible
          • Open
          has a QA test

          Functional Test - A test of a single Moodle feature MDLQA-9814 User is forced to complete required custom user profile fields

          • Minor - Minor loss of function where workaround is possible
          • Open

          Functional Test - A test of a single Moodle feature MDLQA-15295 CLONE - User is forced to complete required custom user profile fields

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Functional Test - A test of a single Moodle feature MDLQA-15884 CLONE - User is forced to complete required custom user profile fields

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Functional Test - A test of a single Moodle feature MDLQA-16530 CLONE - User is forced to complete required custom user profile fields

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Functional Test - A test of a single Moodle feature MDLQA-17146 CLONE - User is forced to complete required custom user profile fields

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Functional Test - A test of a single Moodle feature MDLQA-17734 CLONE - User is forced to complete required custom user profile fields

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Functional Test - A test of a single Moodle feature MDLQA-18238 CLONE - User is forced to complete required custom user profile fields

          • Minor - Minor loss of function where workaround is possible
          • Passed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-56159 Improve how the user_not_fully_setup and auth_forcepasswordchange cases are treated

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32403 A user is not redirected to their profile when required fields are missing

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Improvement - An enhancement to an existing Moodle feature. MDLSITE-3373 Make some aspects of the AMOS UI configurable via user preferences

          • Low - Cosmetic problems, nice-to-have features
          • Resolved

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              muyiwataiwo Olumuyiwa Taiwo
              Olumuyiwa Taiwo Olumuyiwa Taiwo
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Adrian Greeve Adrian Greeve
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              17 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Nov/16