Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46961

Scorm player does not launch for student

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.4
    • Fix Version/s: 2.6.5, 2.7.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide
      1. Please test using Firefox with cache disabled or cleared in browser and cache disabled in Moodle.
      2. Create a SCORM using the options:
        • "Student skip content structure" set to "Always"; and
        • "Display package" option set to "new window"
      3. Make sure pop-up blockers are disabled in browser.
      4. Enter the SCORM as a student (not teacher/admin account)
        • Make sure SCORM package launches in browser correctly.
      Show
      Please test using Firefox with cache disabled or cleared in browser and cache disabled in Moodle. Create a SCORM using the options: "Student skip content structure" set to "Always"; and "Display package" option set to "new window" Make sure pop-up blockers are disabled in browser. Enter the SCORM as a student (not teacher/admin account) Make sure SCORM package launches in browser correctly.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull 2.7 Branch:
      m27_MDL-46961
    • Pull Master Branch:
      master_MDL-46961

      Description

      When the selected value for "Student skip content structure page" is "Always" student could not launch the scorm player and the error displayed in Firebug is "setlaunchoptions is not a function."

      I have solved by placing the setlaunchoptions function above the following if condition
      if (launch == true)

      { setlaunchoptions(); - - - - - }

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              faisalkaleem Faisal Kaleem added a comment -

              Attached is the patch to solve the issue.

              Show
              faisalkaleem Faisal Kaleem added a comment - Attached is the patch to solve the issue.
              Hide
              danmarsden Dan Marsden added a comment -

              thanks for the report and patch - I'll take a look at it this week.

              Show
              danmarsden Dan Marsden added a comment - thanks for the report and patch - I'll take a look at it this week.
              Hide
              danmarsden Dan Marsden added a comment -

              passing this up for integration - thanks Faisal

              Show
              danmarsden Dan Marsden added a comment - passing this up for integration - thanks Faisal
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Dan and Faisal.

              The fix looks right - integrated to 26, 27 and master.

              Show
              damyon Damyon Wiese added a comment - Thanks Dan and Faisal. The fix looks right - integrated to 26, 27 and master.
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Just to confirm, is Firefox the only affected browser?

              Show
              dobedobedoh Andrew Nicols added a comment - Just to confirm, is Firefox the only affected browser?
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Passing, tested on:

              • master
              • 27
              • 26

              Using:

              • Chrome
              • Firefox
              • Safari
              Show
              dobedobedoh Andrew Nicols added a comment - Passing, tested on: master 27 26 Using: Chrome Firefox Safari
              Hide
              danmarsden Dan Marsden added a comment -

              thanks Andrew - I expect other browsers that are more strict with hoisting might have issues but it's only been reported against FF at this stage, and I have used FF in my testing previously and didn't noticed it - I presume it only affects under certain conditions.

              Show
              danmarsden Dan Marsden added a comment - thanks Andrew - I expect other browsers that are more strict with hoisting might have issues but it's only been reported against FF at this stage, and I have used FF in my testing previously and didn't noticed it - I presume it only affects under certain conditions.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Closing as fixed, many thanks for all the hard work!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for all the hard work!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Sep/14