Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46978

Edit grade item changes visibility of category total

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to Course > Grades > Setup > Gradebook setup.
      2. Add a category.
      3. Create a new grade item and select the recent created grade category as parent category.
      4. Hide the category total using the edit menu.
      5. Edit the grade item you've created on this category, change any information field and save.
      6. Verify the category total is still hidden.
      Show
      Go to Course > Grades > Setup > Gradebook setup . Add a category. Create a new grade item and select the recent created grade category as parent category. Hide the category total using the edit menu. Edit the grade item you've created on this category, change any information field and save. Verify the category total is still hidden.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_33_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
      git@github.com:tuanngocnguyen/moodle.git
    • Pull Master Branch:
       MDL-46978-Master

      Description

      If the user change the weight of the grade item on full view page it doesn't change the visibility. However if you click on Edit icon and change any information about the grade item, it also change the visibility of the category total.
      Steps to reproduce the problem.

      1. Go to Course > Grades > Setup > Full View.
      2. Add a category.
      3. Create a new grade item and select the recent created grade category as parent category.
      4. Hide the category total using the eye icon.
      5. Edit the grade item you've created on this category, change any information and save.
      6. Notice the category total is not hidden any more.

      The expected behaviour would be preserve the visibility of the grade category total.

      The code should check if visibility is changing, but it only checks if not hidden (line 597 of lib/grade/grade_item.php and 1692 of lib/grade/grade_category.php).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Nguyen Nathan Nguyen
              Reporter:
              lameze Simey Lameze
              Peer reviewer:
              Dmitrii Metelkin
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              24 Vote for this issue
              Watchers:
              23 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 45 minutes
                  1h 45m