Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46978

Edit grade item changes visibility of category total

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Development in progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.7.1, 2.8, 3.0, 3.1, 3.3.3, 3.5.5, 3.6.4, 3.7
    • Fix Version/s: None
    • Component/s: Gradebook
    • Testing Instructions:
      Hide
      1. Enable preserve category visibility: Site Admin > Grades > Grade Category Settings > tick on Preserve parent category visibility 
      2. Go to Course > Grades > Setup > Gradebook setup
      3. Add a category.
      4. Create a new grade item and select the recent created grade category as parent category.
      5. Hide the category total using the edit menu.
      6. Edit the grade item you've created on this category, change any information field and save.
      7. Notice the category total is hidden.
      Show
      Enable preserve category visibility: Site Admin > Grades > Grade Category Settings > tick on Preserve parent category visibility  Go to Course > Grades > Setup > Gradebook setup Add a category. Create a new grade item and select the recent created grade category as parent category. Hide the category total using the edit menu. Edit the grade item you've created on this category, change any information field and save. Notice the category total is hidden.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_33_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull 3.5 Branch:
      MDL-46978-Master

      Description

      If the user change the weight of the grade item on full view page it doesn't change the visibility. However if you click on Edit icon and change any information about the grade item, it also change the visibility of the category total.
      Steps to reproduce the problem.

      1. Go to Course > Grades > Setup > Full View.
      2. Add a category.
      3. Create a new grade item and select the recent created grade category as parent category.
      4. Hide the category total using the eye icon.
      5. Edit the grade item you've created on this category, change any information and save.
      6. Notice the category total is not hidden any more.

      The expected behaviour would be preserve the visibility of the grade category total.

      The code should check if visibility is changing, but it only checks if not hidden (line 597 of lib/grade/grade_item.php and 1692 of lib/grade/grade_category.php).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                23 Vote for this issue
                Watchers:
                23 Start watching this issue

                Dates

                • Created:
                  Updated: