Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46982

files/renderer.php opening instead of closing <div>

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1) Open /files/renderer.php and see if the change makes sense.
      It should have a </div> instead of an opening <div> tag.

      2) Open the file picker dialog, Inspect element, Make sure It doesn't have <div></div> tags in the end of select dialog.

      Show
      1) Open /files/renderer.php and see if the change makes sense. It should have a </div> instead of an opening <div> tag. 2) Open the file picker dialog, Inspect element, Make sure It doesn't have <div></div> tags in the end of select dialog.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:

      Description

      In Line 799 of /files/renderer.php, at the end of function fp_js_template_selectlayout() there should not be a opening <div> but a closing </div> IMHO.
      No Instruction to reproduce. View the code e.g. in https://github.com/moodle/moodle/blob/master/files/renderer.php.

        Attachments

          Activity

            People

            Assignee:
            shashitechno Shashikant vaishnav
            Reporter:
            lucaboesch Luca Bösch
            Peer reviewer:
            Simey Lameze
            Integrator:
            Dan Poltawski
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Nov/14