Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47002

Atto cleaning sometimes leaves un-closed html comments

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Paste into the editor from MS Word
      2. Right click the editor and inspect element
      3. Navigate through the editor and confirm there are no style tags or similar garbage in the editor tree
      4. On Mac with Word Mac
        1. Paste a sample from Word
        2. Move the cursor back to start of the paste
        3. Hit delete multiple times and confirm the layout doesn't break
      5. In HTML mode, add a <!--
      6. Switch back to WYSIWYG mode then back to HTML
      7. Confirm a closing comment tag was added to balance the missing one. Content should remain in the middle.
      8. In various browsers and OSes confirm
        1. Pasting rich content (word) behaves as expected, both when the cursor is at point or when you start with a selection
        2. Pasting text content (Notepad, TextEdit in plain text mode) behaves as expected, both when the cursor is at point or when you start with a selection
      Show
      Paste into the editor from MS Word Right click the editor and inspect element Navigate through the editor and confirm there are no style tags or similar garbage in the editor tree On Mac with Word Mac Paste a sample from Word Move the cursor back to start of the paste Hit delete multiple times and confirm the layout doesn't break In HTML mode, add a <!-- Switch back to WYSIWYG mode then back to HTML Confirm a closing comment tag was added to balance the missing one. Content should remain in the middle. In various browsers and OSes confirm Pasting rich content (word) behaves as expected, both when the cursor is at point or when you start with a selection Pasting text content (Notepad, TextEdit in plain text mode) behaves as expected, both when the cursor is at point or when you start with a selection
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-47002-master

      Description

      We are running into a problem where when pasting from Microsoft Word on Mac, into firefox, the resulting html has an unclosed comment in it, looking like this:

      <!--
       /* Font Definitions */
      @font-face
      	{font-family:"Antique Olive";
      	panose-1:0 0 0 0 0 0 0 0 0 0;}
       /* Style Definitions */
      p.MsoNormal, li.MsoNormal, div.MsoNormal
      	{"";
      	margin:0in;
      	margin-bottom:.0001pt;
      	font-size:12.0pt;
      	font-family:"Antique Olive";"Times New Roman";"Antique Olive";}
      @page Section1
      	{size:8.5in 11.0in;
      	margin:1.0in 1.25in 1.0in 1.25in;}
      div.Section1
      	{page:Section1;}
      <span style="font-family:&quot;Times New Roman&quot;;Times New Roman&quot;">Class bring ATI IDs.</span></p>
      

      This totally breaks the rendering of the page that it is on.

      We have yet to reproduce the exact scenario that this happens in, but we've had this happens to numerous users (all using Mac, MS Word, and Firefox).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                10 Vote for this issue
                Watchers:
                17 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15