Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47037

Unable to filter gradebook users with Non English names (i.e Hebrew)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enroll several users with English and non English user names to a course.
      2. Navigate to the Gradebook page.
      3. Switch to RTL mode (choose Hebrew language)
      4. Click one of the first name letters filter to display only names that start with the letter you choose.
      5. Switch to LTR mode (choose English language)
      6. Click one of the first name letters filter to display only names that start with the letter you choose.
      Show
      Enroll several users with English and non English user names to a course. Navigate to the Gradebook page. Switch to RTL mode (choose Hebrew language) Click one of the first name letters filter to display only names that start with the letter you choose. Switch to LTR mode (choose English language) Click one of the first name letters filter to display only names that start with the letter you choose.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47037-master

      Description

      Clicking the "נ" (which sounds like "N") letter in the Hebrew alphabet to filter names starting with "נ" does nothing.

      Looking at the code, there is a common mis use of PARAM_ALPHA in the "sifirst" parameter.

      /grade/report/grader/index.php L43-44

      $graderreportsifirst  = optional_param('sifirst', null, PARAM_ALPHA);
      $graderreportsilast   = optional_param('silast', null, PARAM_ALPHA);

      Should be:

      $graderreportsifirst  = optional_param('sifirst', null, PARAM_RAW);
      $graderreportsilast   = optional_param('silast', null, PARAM_RAW);

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              avimoto Avi Levy
              Reporter:
              nadavkav Nadav Kavalerchik
              Peer reviewer:
              Jetha Chan
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15