[MDL-47037] Unable to filter gradebook users with Non English names (i.e Hebrew) - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Enroll several users with English and non English user names to a course.

Navigate to the Gradebook page.

Switch to RTL mode (choose Hebrew language)

Click one of the first name letters filter to display only names that start with the letter you choose.

Switch to LTR mode (choose English language)

Click one of the first name letters filter to display only names that start with the letter you choose.
Show
Enroll several users with English and non English user names to a course. Navigate to the Gradebook page. Switch to RTL mode (choose Hebrew language) Click one of the first name letters filter to display only names that start with the letter you choose. Switch to LTR mode (choose English language) Click one of the first name letters filter to display only names that start with the letter you choose.
Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/jethac/moodle.git
Pull Master Branch:
~~MDL-47037~~-master
Pull Master Diff URL:
https://github.com/jethac/moodle/compare/2d84748...MDL-47037-master

Clicking the "נ" (which sounds like "N") letter in the Hebrew alphabet to filter names starting with "נ" does nothing.

Looking at the code, there is a common mis use of PARAM_ALPHA in the "sifirst" parameter.

/grade/report/grader/index.php L43-44

$graderreportsifirst  = optional_param('sifirst', null, PARAM_ALPHA);

$graderreportsilast   = optional_param('silast', null, PARAM_ALPHA);

Should be:

$graderreportsifirst  = optional_param('sifirst', null, PARAM_RAW);

$graderreportsilast   = optional_param('silast', null, PARAM_RAW);

is duplicated by

MDL-47954 Gradebook can't filter students by Croatian alphabet

MDL-48316 Searching and filtering the gradebook doesn't work

Participants:: Avi Levy, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Jetha Chan, Marina Glancy, Mark Nelson, Michael de Raadt, Nadav Kavalerchik, Petr Skoda, Zvonko Martinovic

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias