Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46658 Prepare and integrate grader code from UCLA
  3. MDL-47063

Classes .overridden and .ajaxoverridden are not changing the styles

XMLWordPrintable

    • MOODLE_28_STABLE
    • MDL-47063-master
    • Hide
      1. Enable Ajax editing for the grader report
      2. Go to the grader report
      3. Override some grades (in 2 consecutive rows, 1 white, 1 grey)
        • The background of the updated cells should change
      4. Refresh the page
        • The background of the cells remained different than the default background

      PS: To enable Ajax, if MDL-46936 was not integrated, use the following fix:

      diff --git a/grade/report/grader/module.js b/grade/report/grader/module.js
      index 9effafe..9c89dc6 100644
      --- a/grade/report/grader/module.js
      +++ b/grade/report/grader/module.js
      @@ -23,8 +23,9 @@ M.gradereport_grader = {
            * @param {Array} An array of feedback objects
            * @param {Array} An array of student grades
            */
      -    init_report : function(Y, id, cfg, items, users, feedback, grades) {
      +    init_report : function(Y, cfg, items, users, feedback, grades) {
               // Create the actual report
      +        var id = 'yo';
               this.reports[id] = new this.classes.report(Y, id, cfg, items, users, feedback, grades);
           }
       };
      

      Show
      Enable Ajax editing for the grader report Go to the grader report Override some grades (in 2 consecutive rows, 1 white, 1 grey) The background of the updated cells should change Refresh the page The background of the cells remained different than the default background PS: To enable Ajax, if MDL-46936 was not integrated, use the following fix: diff --git a/grade/report/grader/module.js b/grade/report/grader/module.js index 9effafe..9c89dc6 100644 --- a/grade/report/grader/module.js +++ b/grade/report/grader/module.js @@ -23,8 +23,9 @@ M.gradereport_grader = { * @param {Array} An array of feedback objects * @param {Array} An array of student grades */ - init_report : function(Y, id, cfg, items, users, feedback, grades) { + init_report : function(Y, cfg, items, users, feedback, grades) { // Create the actual report + var id = 'yo'; this.reports[id] = new this.classes.report(Y, id, cfg, items, users, feedback, grades); } };
    • 5
    • FRONTEND Sprint 14

      The styles for .ajaxoverridden were lost in another issue, they should be restored. Though they will suffer from the same problem than the one happening for .overridden: some other rules (with nth-child()) takes precedence over it and so the background color is not updated. We should make overridden more important.

            fred Frédéric Massart
            fred Frédéric Massart
            Andrew Lyons Andrew Lyons
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.