Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46658 Prepare and integrate grader code from UCLA
  3. MDL-47063

Classes .overridden and .ajaxoverridden are not changing the styles

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable Ajax editing for the grader report
      2. Go to the grader report
      3. Override some grades (in 2 consecutive rows, 1 white, 1 grey)
        • The background of the updated cells should change
      4. Refresh the page
        • The background of the cells remained different than the default background

      PS: To enable Ajax, if MDL-46936 was not integrated, use the following fix:

      diff --git a/grade/report/grader/module.js b/grade/report/grader/module.js
      index 9effafe..9c89dc6 100644
      --- a/grade/report/grader/module.js
      +++ b/grade/report/grader/module.js
      @@ -23,8 +23,9 @@ M.gradereport_grader = {
            * @param {Array} An array of feedback objects
            * @param {Array} An array of student grades
            */
      -    init_report : function(Y, id, cfg, items, users, feedback, grades) {
      +    init_report : function(Y, cfg, items, users, feedback, grades) {
               // Create the actual report
      +        var id = 'yo';
               this.reports[id] = new this.classes.report(Y, id, cfg, items, users, feedback, grades);
           }
       };
      

      Show
      Enable Ajax editing for the grader report Go to the grader report Override some grades (in 2 consecutive rows, 1 white, 1 grey) The background of the updated cells should change Refresh the page The background of the cells remained different than the default background PS: To enable Ajax, if MDL-46936 was not integrated, use the following fix: diff --git a/grade/report/grader/module.js b/grade/report/grader/module.js index 9effafe..9c89dc6 100644 --- a/grade/report/grader/module.js +++ b/grade/report/grader/module.js @@ -23,8 +23,9 @@ M.gradereport_grader = { * @param {Array} An array of feedback objects * @param {Array} An array of student grades */ - init_report : function(Y, id, cfg, items, users, feedback, grades) { + init_report : function(Y, cfg, items, users, feedback, grades) { // Create the actual report + var id = 'yo'; this.reports[id] = new this.classes.report(Y, id, cfg, items, users, feedback, grades); } };
    • Affected Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47063-master
    • Story Points:
      5
    • Sprint:
      FRONTEND Sprint 14

      Description

      The styles for .ajaxoverridden were lost in another issue, they should be restored. Though they will suffer from the same problem than the one happening for .overridden: some other rules (with nth-child()) takes precedence over it and so the background color is not updated. We should make overridden more important.

        Attachments

          Activity

            People

            • Assignee:
              fred Frédéric Massart
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Andrew Nicols
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: