Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47078

Sum of grades does not work with exclude empty grades

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Won't Fix
    • 2.8
    • None
    • Gradebook
    • MOODLE_28_STABLE
    • MDL-47078-master
    • Hide
      1. Run behat tests
      1. Create a grade book with various categories using sum of grades and a few grade items in each category
      2. For some categories, set exclude empty grades to true, and for others set it to false
      3. Go to the grader report and for the first student, grade some items and leave others empty
      4. View the overview report for the student and manually add up the grades and range columns and verify the result matches your expectations
      5. Think of some more tests...
      Show
      Run behat tests Create a grade book with various categories using sum of grades and a few grade items in each category For some categories, set exclude empty grades to true, and for others set it to false Go to the grader report and for the first student, grade some items and leave others empty View the overview report for the student and manually add up the grades and range columns and verify the result matches your expectations Think of some more tests...

    Description

      This was discussed a long time ago and agreed that these options cannot work together (read MDL-14831).

      But there have been some fixes to aggregation methods recently and the people helping with the Natural Weighting method for 2.8 (Mark McKay, Colin Campbell, Robert Puffer) have been using a patch for a while which seems to solve all the issues.

      So - this issue is about:
      a) Defining completely 100% the expected behaviour for teachers and students via test cases
      b) Implementing those test cases as behat tests
      c) Removing this restriction and allowing sum of grades to work with exclude empty grades

      Once this is fixed - we will open a backport request for it.

      Attachments

        Issue Links

          blocks

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-47059 Investigate/fix handling of hidden and excluded grades within natural weights

          • Minor - Minor loss of function where workaround is possible
          • Closed
          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48239 Max Grade of Aspects with Calculation Formula is always 100

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48618 Unexpected changes on grades after upgrade to Moodle 2.8

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-48634 Add option to rescale existing grades when changing max points

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46997 Sum of Grades still not calculating correctly with hidden items

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: