Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47113

Open LTI Tools in new Window, add link when popup is blocked

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.11, 2.5.6, 2.5.7, 2.6.3, 2.6.4, 2.7, 2.7.1, 3.0.3, 3.1, 3.1.1, 3.2
    • Fix Version/s: 3.2
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up a site as an LTI provider (see https://docs.moodle.org/31/en/Publish_as_LTI_tool).
      2. Create at least two activities that are published as LTI tools.
      3. On your integration branch in a course create a new external tool.
      4. Add the credentials of one of the activities and set the launch container to 'New window'
      5. Do the above steps from 3 - 4 again with the other tool.
      6. Open each of the external tools. They should open in new tabs and they should also display their own activity.
      Show
      Set up a site as an LTI provider (see https://docs.moodle.org/31/en/Publish_as_LTI_tool ). Create at least two activities that are published as LTI tools. On your integration branch in a course create a new external tool. Add the credentials of one of the activities and set the launch container to 'New window' Do the above steps from 3 - 4 again with the other tool. Open each of the external tools. They should open in new tabs and they should also display their own activity.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-47113-master

      Description

      Hello when you select to open an LTI tool it always in the same tab or windows

      In https://github.com/moodle/moodle/blob/master/mod/lti/view.php

      echo "window.open('launch.php?id=".$cm->id."','lti');";

      Will be great to change it to

      echo "window.open('launch.php?id=".$cm->id."','lti".$cm->id."');";

      Because if not is not possible to have 2 opened LTI tools at same time

      Slightly changing the tracker item as well:
      Also if popup is blocked, there is no link to open the link.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16