[MDL-47113] Open LTI Tools in new Window, add link when popup is blocked - Moodle Tracker

XML

Word

Printable

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.4.11, 2.5.6, 2.5.7, 2.6.3, 2.6.4, 2.7, 2.7.1, 3.0.3, 3.1, 3.1.1, 3.2
Fix Version/s: 3.2
Component/s: External Tool (IMS-LTI)
Labels:
- ci
- ui_change

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
git://github.com/abgreeve/moodle.git
Pull Master Branch:
wip-~~MDL-47113~~-master
Pull Master Diff URL:
https://github.com/abgreeve/moodle/compare/49619ce...wip-MDL-47113-master
Testing Instructions:
Hide

Set up a site as an LTI provider (see https://docs.moodle.org/31/en/Publish_as_LTI_tool).

Create at least two activities that are published as LTI tools.

On your integration branch in a course create a new external tool.

Add the credentials of one of the activities and set the launch container to 'New window'

Do the above steps from 3 - 4 again with the other tool.

Open each of the external tools. They should open in new tabs and they should also display their own activity.
Show
Set up a site as an LTI provider (see https://docs.moodle.org/31/en/Publish_as_LTI_tool ). Create at least two activities that are published as LTI tools. On your integration branch in a course create a new external tool. Add the credentials of one of the activities and set the launch container to 'New window' Do the above steps from 3 - 4 again with the other tool. Open each of the external tools. They should open in new tabs and they should also display their own activity.

Hello when you select to open an LTI tool it always in the same tab or windows

echo "window.open('launch.php?id=".$cm->id."','lti');";

Will be great to change it to

echo "window.open('launch.php?id=".$cm->id."','lti".$cm->id."');";

Because if not is not possible to have 2 opened LTI tools at same time

Slightly changing the tracker item as well:
Also if popup is blocked, there is no link to open the link.

will help resolve

MDL-42066 Popup blocker prevents External Tool when accessing directly via URL

Participants:: Adrian Greeve, Andrew Lyons, Antoni Bertran Bellido, Ben Kelada, CiBoT, Eloy Lafuente (stronk7), Helen Foster, Ryan Wyllie

Component watchers:: Jake Dallimore, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie