Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47166

Atto: invert indent/outdent buttons (again)

    XMLWordPrintable

Details

    Description

      I took the liberty to create a new bug since my last comment on MDL-44216 went unoticed.

      In moodle master branch (and 2.7 too) , the Indent button order is still INDENT/OUTDENT and, as raised by Frédéric in MDL-44216, this should be reversed for consistency.

      /lib/editor/atto/plugins/indent/yui/src/button/js/button.js

      Y.namespace('M.atto_indent').Button = Y.Base.create('button', Y.M.editor_atto.EditorPlugin, [], {
      initializer: function() {
      this.addButton({
      icon: 'e/increase_indent',
      title: 'indent',
      buttonName: 'indent',
      callback: this.indent
      });
       
      this.addButton({
      icon: 'e/decrease_indent',
      title: 'outdent',
      buttonName: 'outdent',
      callback: this.outdent
      });
      },
      

      By reversing the two addButton statement, we get the correct order.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              jackdaniels JD
              David Monllaó David Monllaó
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Ankit Agarwal Ankit Agarwal
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                2/Feb/15