Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47186

Detailed month view has a h1 for the month name

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.5, 2.7.2, 2.8
    • Fix Version/s: 2.6.6, 2.7.3
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide

      Go to the detailed month month view (Site pages > Calendar) and using your favourite firebug clone, inspect the month and year, and confirm that the heading is a h2 (and no longer h1)

      Show
      Go to the detailed month month view (Site pages > Calendar) and using your favourite firebug clone, inspect the month and year, and confirm that the heading is a h2 (and no longer h1)
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m28_MDL-47186

      Description

      When on a detailed month view (Site pages > Calendar), the month name is a h1. In most themes this means that there is 2 h1's on this page (the first being the site title) which is widely accepted as bad practice

        Attachments

          Activity

            People

            Assignee:
            brianb Brian Barnes
            Reporter:
            brianb Brian Barnes
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Damyon Wiese
            Tester:
            Aparup Banerjee
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Nov/14