Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47232

Course completion: "activities to be completed" improperly requires passing grade

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable activity and course completion
      2. Create a quiz activity
        • In Activity completion section of the quiz you are creating
          • Completion tracking to when conditions are met
          • Do not check "require passing grade" or "require grade of ___" for the activity.
      3. Set course completion settings to require completion of an activity.
      4. Set a passing grade on the activity
      5. Log in as student
      6. Complete the activity, with a failing score.
      7. Run cron, wait, run cron again.
      8. View course completion report.
      9. The course should be marked complete because the required activity is completed.
      Show
      Enable activity and course completion Create a quiz activity In Activity completion section of the quiz you are creating Completion tracking to when conditions are met Do not check "require passing grade" or "require grade of ___" for the activity. Set course completion settings to require completion of an activity. Set a passing grade on the activity Log in as student Complete the activity, with a failing score. Run cron, wait, run cron again. View course completion report. The course should be marked complete because the required activity is completed.
    • Workaround:
      Hide

      None.

      To get the old behavior, after the fix, explicitly set it by checking the box "require passing grade" or filling in "require grade ___".

      Show
      None. To get the old behavior, after the fix, explicitly set it by checking the box "require passing grade" or filling in "require grade ___".
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47232_master

      Description

      Course completion aggregation does not work as conditional activities works, and one might expect it to work. It silently adds the "require passing grade" criteria to all activities, even if the teacher has unchecked that option.

      For example, if teacher sets course completion to require:

      that the student complete the pretest quiz
      view the scorm module
      take the final quiz

      It does not mark the course as complete when those three activities are marked as complete. Instead, the course will only be marked complete if the student both completes the pretest AND ALSO achieves a passing grade on the pretest.

      This means that in the completion report, the teacher may see that all of the required activities are marked complete, but the course isn't marked complete. This caused consternation and confusion - all of the required activities were marked complete, but the course wouldn't mark complete.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15