Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47247

Folders created by dragging zip folder on to course page ignoring changed site default for showexpanded

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.5, 3.5.3, 3.6, 3.7
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Resource
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites:

      1. Zip up a folder containing subfolders, with the subfolders containing files.
      2. Create a Course.

      Test 1. (test drag-and-drop folder creation)

      1. Go to Site Administration > Plugins > Activity modules > Folder.
      2. Disable 'Show subfolders expanded'.
      3. Go to the Course and turn editing on.
      4. Drag the zipped folder on to the course page and select "Unzip files and create folder".
      5. Edit the newly created Folder.
        • make sure the Folder has 'Show subfolders expanded' set to disabled.
      6. Go to Site Administration > Plugins > Activity modules >Folder.
      7. Enable 'Show subfolders expanded'.
      8. Repeat the steps 3-5.
        • make sure the Folder has 'Show subfolders expanded' set to enabled.

      Test 2 (test standard folder creation)

      1. Go to Site Administration > Plugins > Activity modules >Folder.
      2. Disable 'Show subfolders expanded'.
      3. Go to the Course and turn editing on.
      4. Add a Folder resource.
        • enable 'Show subfolders expanded'.
        • upload and unzip the folder.
      5. Edit the newly created Folder.
        • make sure the folder has the 'Show subfolders expanded' setting enabled and does not inherit the site setting.
      Show
      Prerequisites: Zip up a folder containing subfolders, with the subfolders containing files. Create a Course. Test 1. (test drag-and-drop folder creation) Go to Site Administration > Plugins > Activity modules > Folder. Disable 'Show subfolders expanded'. Go to the Course and turn editing on. Drag the zipped folder on to the course page and select "Unzip files and create folder". Edit the newly created Folder. make sure the Folder has 'Show subfolders expanded' set to disabled. Go to Site Administration > Plugins > Activity modules >Folder. Enable 'Show subfolders expanded'. Repeat the steps 3-5. make sure the Folder has 'Show subfolders expanded' set to enabled. Test 2 (test standard folder creation) Go to Site Administration > Plugins > Activity modules >Folder. Disable 'Show subfolders expanded'. Go to the Course and turn editing on. Add a Folder resource. enable 'Show subfolders expanded'. upload and unzip the folder. Edit the newly created Folder. make sure the folder has the 'Show subfolders expanded' setting enabled and does not inherit the site setting.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-47247-master
    • Pull Master Diff URL:

      Description

      If Show subfolders expanded is set to 'No' at site level, when a folder is created by dragging a zip file on to a course page, the folder is created with showexpanded = 1.

      1. Turn off show subfolders expanded in Site Administration.
      2. Zip up a folder containing subfolders, with the subfolders containing files.
      3. Go to a course page and turn editing on.
      4. Drag the zipped folder on to the course page and select "Unzip files and create folder".
      5. The newly created folder has showexpanded set to 1.

      When a new folder is created using the file picker, it works correctly.

        Attachments

          Activity

            People

            Assignee:
            Geshoski Mihail Geshoski
            Reporter:
            lawrie34 Barbara Lawrence
            Peer reviewer:
            Damyon Wiese
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m