Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47273

Not displayed "more" link in the journal if users or groups more than 1000

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Minor
    • None
    • 2.7, 2.7.1, 2.7.2
    • Logging
    • None
    • MOODLE_27_STABLE

    Description

      Not displayed "more" link in the journal if users or groups more than 1000 ( var COURSE_MAX_COURSES_PER_DROPDOWN and COURSE_MAX_USERS_PER_DROPDOWN in /course/lib.php )
      in logging http://moodle.xxx/report/log/index.php?id=0

      bug in file
      /report/log/classes/renderer.php

      I have proposed to correct an error patch
      Bad english, sorry.

      86c86
      <         if (!empty($courses)) {
      ---
      >         //if (!empty($courses)) { // Baffling check because it will never affect link
      100c100
      <                     $a->url = new moodle_url('/report/log/index.php', array('chooselog' => 0,
      ---
      >                     $url = new moodle_url('/report/log/index.php', array('chooselog' => 0,
      103,104c103,105
      <                         'showcourses' => 1, 'showusers' => $reportlog->showusers));
      <                     print_string('logtoomanycourses', 'moodle', $a);
      ---
      >                         'showcourses' => 1, 'showusers' => $reportlog->showusers));
      > 		    $a->url = $url->out();
      > 		    print_string('logtoomanycourses', 'moodle', $a);
      107c108
      <         }
      ---
      >         //}
      118c119
      <         if (!empty($users)) {
      ---
      >         //if (empty($users)) {
      132c133
      <                 $a->url = new moodle_url('/report/log/index.php', array('chooselog' => 0,
      ---
      >                 $url = new moodle_url('/report/log/index.php', array('chooselog' => 0,
      135c136,137
       
      <                     'showcourses' => 1, 'showusers' => $reportlog->showusers, 'showcourses' => $reportlog->showcourses));
      ---
      >                     'showusers' => 1, 'showcourses' => $reportlog->showcourses)); \\copy-paste little bug
      > 		$a->url = $url->out();   
      138c140
      <         }
      ---
      >         //}
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              vladimirzzz Vladimir Zemlyakov
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.