Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47404

scorm packages failing due to content-disposition header in send_file

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.5
    • Fix Version/s: 2.6.6, 2.7.3
    • Component/s: Files API, SCORM
    • Labels:
    • Testing Instructions:
      Hide

      as this is a change to a massively important function we probably need to make sure we test this well.

      The SCORM test is relatively easy but I cannot provide a publicly accessible package to reproduce this. I can provide a test package to the QA team as I have approval from the client to do this. All you need to do is add this package to a course and check to see if it loads.

      If there are ways of embedding flash(swf) content within courses we should test those.

      Show
      as this is a change to a massively important function we probably need to make sure we test this well. The SCORM test is relatively easy but I cannot provide a publicly accessible package to reproduce this. I can provide a test package to the QA team as I have approval from the client to do this. All you need to do is add this package to a course and check to see if it loads. If there are ways of embedding flash(swf) content within courses we should test those.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      master_MDL-47404

      Description

      I've been trying to trace this for ages to work out where the issue is, I have a scorm package that works fine when the content sits outside Moodle but when the package sits in moodledata and is parsed through the moodle file api it throws a weird flash error.

      turns out that it is related to the filename component of the content-disposition header in send_file() - I haven't worked out why or how best to fix this yet.

        Attachments

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14