Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47431

incorrect param passed to get_grading_manager from navigationlib

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Add a new assignment to a course and set an advanced grading method to be used (rubrics or marking guide)

      Check to make sure the link to "Advanced grading" appears in the admin block when viewing the assignment.

      Show
      Add a new assignment to a course and set an advanced grading method to be used (rubrics or marking guide) Check to make sure the link to "Advanced grading" appears in the admin block when viewing the assignment.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      master_MDL-47431

      Description

      in lib/navigationlib.php in function load_activity()

      the following call is made:
      $gradingman = get_grading_manager($cm->context, $cm->modname);

      in load_module_settings() the following call is made:
      $gradingman = get_grading_manager($this->page->cm->context, $this->page->activityname);

      All other uses of get_grading_manager (including the info in it's phpdoc) specifies that the frankenstyle name (mod_assign) should be passed instead.

      I haven't seen an issue with the assign module but I'm working on adding support for advanced grading to the forum module and I noticed this variance.

      We need to fix this to use the correct/consistent use of frankenstyle naming and check to make sure this doesn't cause issues with settings appearing in the navigation block

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                danmarsden Dan Marsden
                Reporter:
                danmarsden Dan Marsden
                Peer reviewer:
                Marina Glancy
                Integrator:
                Damyon Wiese
                Tester:
                Damyon Wiese
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14