Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47475

PDF annotation - when a group assignment is submitted by one student, the others members cannot preview the annotations

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Run behat suite
      Preparation

      You will need:

      1. a course
      2. 1 editing teaching
      3. 10 students grouped into three groups:
        1. Group 1: students G1S1, G1S2
        2. Group 2: students G2S1, G2S2
        3. Group 3: students G3S1, G3S2, G3S3
        4. Group 4: students G4S1, G4S2, G4S3
      4. 1 assignment with group marking enabled
      Testing
      Test Save as one, view as another
      1. Login as G1S1 and submit a pdf to the assignment
      2. Login as teacher, mark the assignment for G1S1, and add some annotations, saving the changes
      3. Login as G1S1 and try to view the annotations
        • Confirm that the annotations are all present and correct
      4. Login as G1S2 and try to view the annotations
        • Confirm that the annotations are all present and correct
      Test Save as one, Mark a second
      1. Login as G2S1 and submit a pdf to the assignment
      2. Login as teacher, mark the assignment for G2S2, and add some annotations, saving the changes.
      3. Login as G2S1 and view the submission
        • Confirm that the annotations are all present and correct
      4. Login as G2S2 and view the submission
        • Confirm that the annotations are all present and correct
      Test Save as one, Mark a second, View third
      1. Login as G3S1 and submit a pdf to the assignment
      2. Login as teacher, mark the assignment for GSS2, and add some annotations, saving the changes.
      3. Login as GSS3 and view the submission
        • Confirm that the annotations are all present and correct
      4. Login as GSS1 and view the submission
        • Confirm that the annotations are all present and correct
      5. Login as GSS2 and view the submission
        • Confirm that the annotations are all present and correct
      Test that items are not copied when not applying to entire group
      1. Login as G4S1 and submit a pdf to the assignment
      2. Login as teacher
      3. Mark the assignment for G4S1:
        1. Add some annotations
        2. Apply grades and feedback to entire group: No
        3. saving the changes.
      4. Mark the assignment for G4S2:
        1. Add some annotations
        2. Apply grades and feedback to entire group: No
        3. saving the changes.
      5. Login as G4S1 and view the submission
        • Confirm that the annotations are all present and correct
      6. Login as G4S2 and view the submission
        • Confirm that the annotations are all present and correct
      7. Login as G4S3 and view the submission
        • Confirm that the pdf is not available
      Test fix for existing data
      1. Revert the patch
      2. Create a new assignment
      3. Login as G1S1
      4. Submit a PDF
      5. Login as teacher
      6. Mark and add annotations for G1S1, applying to all group members on Save
      7. Re-apply the patch
      8. Login as G1S2 and view the submission
        • Confirm that the annotations are all present and correct
      9. Login as G1S1 and view the submission
        • Confirm that the annotations are all present and correct
      Show
      Run behat suite Preparation You will need: a course 1 editing teaching 10 students grouped into three groups: Group 1: students G1S1, G1S2 Group 2: students G2S1, G2S2 Group 3: students G3S1, G3S2, G3S3 Group 4: students G4S1, G4S2, G4S3 1 assignment with group marking enabled Testing Test Save as one, view as another Login as G1S1 and submit a pdf to the assignment Login as teacher, mark the assignment for G1S1, and add some annotations, saving the changes Login as G1S1 and try to view the annotations Confirm that the annotations are all present and correct Login as G1S2 and try to view the annotations Confirm that the annotations are all present and correct Test Save as one, Mark a second Login as G2S1 and submit a pdf to the assignment Login as teacher, mark the assignment for G2S2, and add some annotations, saving the changes. Login as G2S1 and view the submission Confirm that the annotations are all present and correct Login as G2S2 and view the submission Confirm that the annotations are all present and correct Test Save as one, Mark a second, View third Login as G3S1 and submit a pdf to the assignment Login as teacher, mark the assignment for GSS2, and add some annotations, saving the changes. Login as GSS3 and view the submission Confirm that the annotations are all present and correct Login as GSS1 and view the submission Confirm that the annotations are all present and correct Login as GSS2 and view the submission Confirm that the annotations are all present and correct Test that items are not copied when not applying to entire group Login as G4S1 and submit a pdf to the assignment Login as teacher Mark the assignment for G4S1: Add some annotations Apply grades and feedback to entire group: No saving the changes. Mark the assignment for G4S2: Add some annotations Apply grades and feedback to entire group: No saving the changes. Login as G4S1 and view the submission Confirm that the annotations are all present and correct Login as G4S2 and view the submission Confirm that the annotations are all present and correct Login as G4S3 and view the submission Confirm that the pdf is not available Test fix for existing data Revert the patch Create a new assignment Login as G1S1 Submit a PDF Login as teacher Mark and add annotations for G1S1, applying to all group members on Save Re-apply the patch Login as G1S2 and view the submission Confirm that the annotations are all present and correct Login as G1S1 and view the submission Confirm that the annotations are all present and correct
    • Workaround:
      Hide

      A workaround is to simply download the PDF with the annotations in order to view it normaly.

      Show
      A workaround is to simply download the PDF with the annotations in order to view it normaly.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-47475-master
    • Sprint:
      FRONTEND Sprint 16
    • Issue size:
      Small

      Description

      From what I know, this is actually a regression caused by MDL-45582. I may be wrong, but this is what we detected in our team.

      When a student submits an assignment for his group and the teacher annotates it, the other members of the group cannot preview PDF (pdf editor) because either an error occurs or the editor never generates the annotations.

        Attachments

        1. Error.png
          Error.png
          6 kB
        2. Étudiant_erreur.png
          Étudiant_erreur.png
          45 kB
        3. Étudiant_preview annotation.png
          Étudiant_preview annotation.png
          9 kB
        4. generating forever.png
          generating forever.png
          8 kB
        5. View annoted.png
          View annoted.png
          49 kB

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              melrome Melvin Romero
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Dan Poltawski
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              5 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15