Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47546

Unreleased lock throws exception outside of phpunit

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Won't Do
    • 2.7.2, 2.8.1, 3.0.3, 3.3, 3.5.5, 3.6.3
    • None
    • Tasks

    Description

      It looks like the phpunit check is incomplete in lock destructor. While testing MDL-46210 my normal (non-unittest) cron run failed where it should not have.

      https://github.com/moodle/moodle/blob/master/lib/classes/lock/lock.php#L105 should be:

      - if (!$this->released && defined('PHPUNIT_TEST')) {
      		 
      + if (!$this->released && defined('PHPUNIT_TEST') && PHPUNIT_TEST) {

      The lock should be released regardless of unittests

      Attachments

        Issue Links

          Discovered while testing

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-46210 Provide option to update installed language packs as a scheduled task

          • Major - Major loss of function, incorrect output
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-56609 Random failure: core_scheduled_task_testcase::test_get_next_scheduled_task

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48593 Incoming file email failing with php coding error

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-47480 Scheduled Tasks are returned in random order by get_next_scheduled_task

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-61447 refresh_mod_calendar_events_task does not release lock when running cron in parallel

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59546 core\lock\lock::__destruct hides potentially thrown exception

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-47564 Availability: incorrect use of defined('PHP_UNIT')

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              marina Marina Glancy
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              2 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h