-
Bug
-
Resolution: Won't Do
-
Minor
-
None
-
2.7.2, 2.8.1, 3.0.3, 3.3, 3.5.5, 3.6.3
-
MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_30_STABLE, MOODLE_33_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
-
MDL-47546_master
It looks like the phpunit check is incomplete in lock destructor. While testing MDL-46210 my normal (non-unittest) cron run failed where it should not have.
https://github.com/moodle/moodle/blob/master/lib/classes/lock/lock.php#L105 should be:
- if (!$this->released && defined('PHPUNIT_TEST')) {
|
+ if (!$this->released && defined('PHPUNIT_TEST') && PHPUNIT_TEST) {
|
The lock should be released regardless of unittests
- Discovered while testing
-
MDL-46210 Provide option to update installed language packs as a scheduled task
-
- Closed
-
- has a non-specific relationship to
-
-
- Closed
-
- has been marked as being related by
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
- is duplicated by
-
-
- Closed
-
- will be (partly) resolved by
-
-
- Closed
-
