Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47560

Change 'Got it' to something more formal and remove unset config settings.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      Setup: Start with a version of Moodle that is before the gradebook overhaul (I just started with 2.7).

      • Create multiple courses (2 will do) and make sure the aggregation type is "Sum of grades". Note the id of the courses (referred to in future steps as $courseid).
      • Upgrade Moodle to the 2.8 code (what is in integration_master at the moment will do).
      • Query the mdl_config table for the "show sum of grades upgrade notice" config settings (I used mySQL):

        select * from mdl_config where name="show_sumofgrades_upgrade_$courseid"

        and note that this query should return 1 row for each course.

      • Go to the grader report for each course and observe that there is a notice letting the user know that since the upgrade there have been reworks to the gradebook (it's the sumofgradesupgradedgrades lang string). Click the "OK" button.
      • Perform the same queries from before. They should now return 0 rows.
      Show
      Setup: Start with a version of Moodle that is before the gradebook overhaul (I just started with 2.7). Create multiple courses (2 will do) and make sure the aggregation type is "Sum of grades". Note the id of the courses (referred to in future steps as $courseid). Upgrade Moodle to the 2.8 code (what is in integration_master at the moment will do). Query the mdl_config table for the "show sum of grades upgrade notice" config settings (I used mySQL): select * from mdl_config where name="show_sumofgrades_upgrade_$courseid" and note that this query should return 1 row for each course. Go to the grader report for each course and observe that there is a notice letting the user know that since the upgrade there have been reworks to the gradebook (it's the sumofgradesupgradedgrades lang string). Click the "OK" button. Perform the same queries from before. They should now return 0 rows.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47560-master

      Description

      Please see the last two comments in MDL-47062

      A lot of configuration settings could be generated if there are a lot of courses using the 'Sum of grades' aggregation. These could be unset as each course is viewed and acknowledged by the user.

      The string 'Got it' has been deemed too casual and it has been requested that we change it to something else

      How about having a button 'OK' or maybe 'Continue'?

      'Note: The aggregation method "Sum of grades" has been changed to "Natural" as part of a site upgrade. Since "Sum of grades" was previously used in this course, it is recommended that you review this change in the gradebook.'

        Attachments

          Activity

            People

            Assignee:
            davecooper Dave Cooper
            Reporter:
            abgreeve Adrian Greeve
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Dan Poltawski
            Tester:
            Zachary Durber
            Participants:
            Component watchers:
            Jake Dallimore, Jun Pataleta
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Nov/14