Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47602

moodle-core-notification should listen for widget:contentUpdate

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.7.2
    • Fix Version/s: FRONTEND
    • Component/s: JavaScript
    • Labels:

      Description

      Frédéric Massart found this when testing MDL-43089. If (due to an Ajax call say) the contents of a dialogue changes a lot, you may want to change the fully-screen-ness, or whether the page scroll bars are available.

      I think the right way to handle this is for the dialogue subclass that is changing the content to fire a widget:contentUpdate event, and then moodle-core-notification base class subscribe to that, and re-do some of the logic from visibilityChanged.

      For now, in my code, I have done a short-term hack of

              this.dialogue.hide();
              this.dialogue.show();
      

      but you probably want to fix this properly at some point.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              timhunt Tim Hunt
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: