Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47637

Outcome items have incorrect weights when not included in Natural aggregation

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable outcomes
      2. Create a course and add an manual item and an outcome item to the gradebook
      3. Make sure you cannot edit the weight of the outcome, through the main screen, or the edit page
      4. Make sure the weight of the other item is correct (should be 100%)
      5. Edit its parent category and enable "Include outcomes in aggregation"
      6. Make sure you can now edit the weight of the outcome, through the main screen, or the edit page
      7. Make sure the weights are correct
      Show
      Enable outcomes Create a course and add an manual item and an outcome item to the gradebook Make sure you cannot edit the weight of the outcome, through the main screen, or the edit page Make sure the weight of the other item is correct (should be 100%) Edit its parent category and enable "Include outcomes in aggregation" Make sure you can now edit the weight of the outcome, through the main screen, or the edit page Make sure the weights are correct
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47637-master

      Description

      When using Natural aggregation, outcome items have incorrect weights when outcomes are not included in aggregation for the category they are in. The weights are calculated as if the outcome items were included. However, the aggregation calculation is correct, just it could be confusing. The automatic weights assigned to outcomes should be 0 when outcomes are not included and should be changed to natural weight if outcomes are included.

      Reproduction steps

      1. Go to admin settings and enable outcomes
      2. Create a course
      3. Add an ordinary grade item (either an activity module, or just add on Grades > Setup > Categories and items)
      4. Create an outcome
      5. Add the outcome to the course
      6. Add an outcome grade item (Grades > Setup > Categories and items)
      7. The course total will only be the max value of the ordinary grade item, and the outcome item will not contribute to score. (outcome items are not included by default) However, the weight displayed is incorrect.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              johno John Okely
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Dan Poltawski
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Damyon Wiese, Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14