[MDL-47666] auth_db_testcase and enrol_database_testcase can't cope with custom DB drivers - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.2
Fix Version/s: 2.6.6, 2.7.3
Component/s: Authentication, Enrolments, Unit tests
Labels:
- triaged

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-47666~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-47666
Testing Instructions:
Hide

1. Run the unit tests with every supported DB.
2. Also, make a new DB driver

class my_crazy_db_driver extends pgsql_native_moodle_database {}

and change your config.php to use it. Run the unit tests with that.
Show
1. Run the unit tests with every supported DB. 2. Also, make a new DB driver class my_crazy_db_driver extends pgsql_native_moodle_database {} and change your config.php to use it. Run the unit tests with that.

Description

They look at get_class($DB) when clearly they should use $DB->get_family()

Attachments

Issue Links

Testing discovered

MDL-47807 PHP Unit failure with user graded event

Closed

MDL-47808 Unit tests failures with forum subscriptions (MySQL and Oracle)

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Ray Guo

Integrator:: Dan Poltawski

Tester:: Frédéric Massart

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, Frédéric Massart, Marina Glancy, Petr Skoda, Ray Guo, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 15/Oct/14 2:22 AM

Updated:: 23/Oct/14 1:22 AM

Resolved:: 23/Oct/14 1:22 AM

Fix Release Date:: 10/Nov/14