Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47666

auth_db_testcase and enrol_database_testcase can't cope with custom DB drivers

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Run the unit tests with every supported DB.
      2. Also, make a new DB driver

      class my_crazy_db_driver extends pgsql_native_moodle_database {}
      

      and change your config.php to use it. Run the unit tests with that.

      Show
      1. Run the unit tests with every supported DB. 2. Also, make a new DB driver class my_crazy_db_driver extends pgsql_native_moodle_database {} and change your config.php to use it. Run the unit tests with that.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      They look at get_class($DB) when clearly they should use $DB->get_family()

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Ray Guo
              Integrator:
              Dan Poltawski
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14