Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47684

Exception when activity form is not fully completed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This will be covered by MDLQA-7301 and MDLQA-7299 BUT a bit of extra testing would help ensure this does not break anything else:

      Note: There is a warning you will get round steps 3/4 about htmlspecialchars being given an array rather than a string - this is expected and will be fixed by MDL-47752

      1. Log in as a teacher
      2. Create a new forum setting:
        • Aggregation type to average
        • Scale to none
        • Completion tracking to "Show activity as complete when conditions are met"
        • Check require grade
      3. Click Save and Display
      4. Check you get a validation error on Aggregation type about needing to select a scale
      5. Select a scale
      6. Click Save and Display and check it works this time.
      7. Create a second forum and this time just give it the required fields.
      8. Check it works correctly.
      9. Edit the second forum you created and try to set an aggregation type but not a scale.
      10. Check you get that same validation error again.
      11. Repeat the above with glossaries
      12. Test creating an assignment activity
      Show
      This will be covered by MDLQA-7301 and MDLQA-7299 BUT a bit of extra testing would help ensure this does not break anything else: Note: There is a warning you will get round steps 3/4 about htmlspecialchars being given an array rather than a string - this is expected and will be fixed by MDL-47752 Log in as a teacher Create a new forum setting: Aggregation type to average Scale to none Completion tracking to "Show activity as complete when conditions are met" Check require grade Click Save and Display Check you get a validation error on Aggregation type about needing to select a scale Select a scale Click Save and Display and check it works this time. Create a second forum and this time just give it the required fields. Check it works correctly. Edit the second forum you created and try to set an aggregation type but not a scale. Check you get that same validation error again. Repeat the above with glossaries Test creating an assignment activity
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      47684-28
    • Pull Master Diff URL:

      Description

      Reported while testing MDLQA-7299

      I guess this is not a recent regression.

      1. Enable completion
      2. Create a forum
      3. Edit a forum, set
      • rating aggregation method to "Average",
      • select "None" in "Scale";
      • Completion when conditions are met: student receive a grade
      1. Save the form

      Fatal error as reported in MDLQA-7299 occur.

      Interesting that when I set the scale to "None" when actually creating forum there is no error and I have a funny feeling this was already reported and partially fixed

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                samhemelryk Sam Hemelryk
                Reporter:
                marina Marina Glancy
                Peer reviewer:
                Marina Glancy
                Integrator:
                Dan Poltawski
                Tester:
                Mark Nelson
                Participants:
                Component watchers:
                Sam Marshall, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14