Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47694

Assignment summary does not count ungraded users properly

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47694-master
    • Testing Instructions:
      Hide

      Test One:

      • Just run behats for mod_assign
        • Specifically: it's mod/assign/tests/behat/quickgrading.feature

      You can also run through the 'Steps to reproduce' from the description and the final step, step 11 should be: You should see: Shows 1 for submitted and 1 for needs grading.

      Show
      Test One: Just run behats for mod_assign Specifically: it's mod/assign/tests/behat/quickgrading.feature You can also run through the 'Steps to reproduce' from the description and the final step, step 11 should be: You should see: Shows 1 for submitted and 1 for needs grading.
    • Sprint:
      FRONTEND Sprint 16
    • Issue size:
      Large

      Description

      timemodified for grades can be set even when the grade is still null. This leads to circumstances where teachers are misinformed as to which grades are still pending a grade.

      Steps to reproduce:

      1. In a course, create an assignment.
        1. Under submission types allow for 'Online text'
      2. Login as Student
      3. Submit anything for your assignment.
      4. Login as Teacher/Admin
      5. Click on that assignment.
      6. You should see: 1 for submitted and 1 for needs grading.
      7. Click on View/grade all submissions.
      8. Edit grade.
      9. Immediately save without changing the grade or feedback.
      10. Head back to the assignment page.
      11. You should see: Shows 1 for submitted and 0 for needs grading.

      You'd assume if the grade is still NULL, despite adding feedback or not that it would indicate the grade has not been graded.
      This is consistent with what the student sees, as it indicates on their view that their Grading status is Not graded.

      Changing this should not effect the behaviour of notifying a student when feedback is submitted, regardless of if the grade is graded.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              howardsmiller Howard Miller
              Reporter:
              howardsmiller Howard Miller
              Peer reviewer:
              Zachary Durber Zachary Durber
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Dave Cooper Dave Cooper
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15