Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47704

Incorrect weight and contribution can be displayed on the user report

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      • Create a few manual items (or gradeable activities).
      • Make sure they all have a weight, even automatic, then grade a student on those.
      • Change one of the items not to contribute any more, for instance switch it type 'text' or 'none'. Verify that the calculated weight column in the user report shows "0.00 %" for these items.
      • Enable outcomes, create a outcome grade item
      • Enable outcomes in aggregation on the category
      • Grade a student on the outcome item
      • Disable outcomes in aggregation on the category
      • Check that the calculated weight on the user report shows "0.00%"

      Test 2

      Testing MDL-47785 which this issue should take care of

      • Requires a course with multiple grades and students
      1. Log in as teacher/admin
      2. Navigate to a course's Grader report
      3. Turn Editing on
      4. For the grade item of a student, click the Edit cog
      5. Check the Excluded checkbox
      6. Save changes
      7. Go to the User report
      8. Select the student from the drop-down menu
      9. Check that the weight for the excluded grade is a dash with the word "(Dropped)". The value in the Contribution to course total should be zero.
      Show
      Create a few manual items (or gradeable activities). Make sure they all have a weight, even automatic, then grade a student on those. Change one of the items not to contribute any more, for instance switch it type 'text' or 'none'. Verify that the calculated weight column in the user report shows "0.00 %" for these items. Enable outcomes, create a outcome grade item Enable outcomes in aggregation on the category Grade a student on the outcome item Disable outcomes in aggregation on the category Check that the calculated weight on the user report shows "0.00%" Test 2 Testing MDL-47785 which this issue should take care of Requires a course with multiple grades and students Log in as teacher/admin Navigate to a course's Grader report Turn Editing on For the grade item of a student, click the Edit cog Check the Excluded checkbox Save changes Go to the User report Select the student from the drop-down menu Check that the weight for the excluded grade is a dash with the word "(Dropped)". The value in the Contribution to course total should be zero.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47704-master

      Description

      Whenever a student's grade was given a hint, but later on this item was changed to be 'text' or 'none'. Then the contribution can still appear on the user report which is misleading and incorrect.

      I think that the problem comes from the set_aggregationused() method which only ever works on the items that were aggregated. Thus if one item is not aggregated any more its hint is invalid.

      To replicate, create a few manual items (or gradeable activities). Make sure they all have a weight, even automatic, then grade a student on those. Change one of the items not to contribute any more, for instance switch it type 'text' or 'none'. You will notice that the contribution and weight columns on the user report display misleading information.

      This could also be replicated when outcomes are switch from/to being aggregated (category setting).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14