Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47790

Almost each /mod/{modulename}/index.php file provide a page beaking html strict standard.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.6.6, 2.7.3
    • Component/s: HTML and CSS
    • Labels:
    • Testing Instructions:
      Hide

      To reproduce the bug simply...
      -> Go to a course divided into sections
      -> add two instances of the module :modulename INTO TWO DIFFERENT sections.
      -> visit the page mod/:modulename/index.php?id=:courseid
      -> make an html validation

      Show
      To reproduce the bug simply... -> Go to a course divided into sections -> add two instances of the module :modulename INTO TWO DIFFERENT sections. -> visit the page mod/:modulename/index.php?id=:courseid -> make an html validation
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47790-master

      Description

      The offending line is: $table->data[] = 'hr';
      It adds an html like <td colspan="xx"> that is not allowed if not included into a tr tag.
      The bug is in /lib/outputcomponents.php

      To reproduce the bug simply...
      -> Go to a course divided into sections
      -> add two instances of the module :modulename INTO TWO DIFFERENT sections.
      -> visit the page mod/:modulename/index.php?id=:courseid
      -> make an html validation

      To fix the issue:
      apply the patch I provided.

      In the frame of this issue, please, find a word to explain me why https://github.com/moodlehq/moodle-mod_newmodule/blob/master/index.php still uses add_to_log

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14