Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47790

Almost each /mod/{modulename}/index.php file provide a page beaking html strict standard.

    XMLWordPrintable

Details

    • MOODLE_28_STABLE
    • MOODLE_26_STABLE, MOODLE_27_STABLE
    • MDL-47790-master
    • Hide

      To reproduce the bug simply...
      -> Go to a course divided into sections
      -> add two instances of the module :modulename INTO TWO DIFFERENT sections.
      -> visit the page mod/:modulename/index.php?id=:courseid
      -> make an html validation

      Show
      To reproduce the bug simply... -> Go to a course divided into sections -> add two instances of the module :modulename INTO TWO DIFFERENT sections. -> visit the page mod/:modulename/index.php?id=:courseid -> make an html validation

    Description

      The offending line is: $table->data[] = 'hr';
      It adds an html like <td colspan="xx"> that is not allowed if not included into a tr tag.
      The bug is in /lib/outputcomponents.php

      To reproduce the bug simply...
      -> Go to a course divided into sections
      -> add two instances of the module :modulename INTO TWO DIFFERENT sections.
      -> visit the page mod/:modulename/index.php?id=:courseid
      -> make an html validation

      To fix the issue:
      apply the patch I provided.

      In the frame of this issue, please, find a word to explain me why https://github.com/moodlehq/moodle-mod_newmodule/blob/master/index.php still uses add_to_log

      Attachments

        Issue Links

          Activity

            People

              daniss Daniele Cordella
              daniss Daniele Cordella
              Jetha Chan Jetha Chan
              Damyon Wiese Damyon Wiese
              Sam Hemelryk Sam Hemelryk
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.