Loading...

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-47874~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/master...MDL-47874
Testing Instructions:
Hide

1) TEST: Verify that dml tests are passing under all DBs (vendor/bin/phpunit lib/dml/tests/dml_test.php) with zero skipped.
2) In a Oracle installed site:

Add some content to be replaced here and there (some description, course name, a post...).

Go to the replace admin tool (admin/tool/replace/)

Search for the content you just introduced and replace it by another one.

Perform the search/replace (Yes, do it! button). Can be long, with debugging enabled you should see the SQL happening...

TEST: Verify that the contents have been properly replaced in the places you originally introduced them.
Show
1) TEST: Verify that dml tests are passing under all DBs (vendor/bin/phpunit lib/dml/tests/dml_test.php) with zero skipped. 2) In a Oracle installed site: Add some content to be replaced here and there (some description, course name, a post...). Go to the replace admin tool (admin/tool/replace/) Search for the content you just introduced and replace it by another one. Perform the search/replace (Yes, do it! button). Can be long, with debugging enabled you should see the SQL happening... TEST: Verify that the contents have been properly replaced in the places you originally introduced them.

for some reason in ~~MDL-31625~~ Oracle was left out as database not supporting REPLACE function but it does.

Either:

Implement oci_native_moodle_database::replace_all_text_supported() to return true
Remove the function replace_all_text_supported() and all of it's usages (leave it in moodle_database as returning true)

Make sure all unittests pass on oracle

Discovered while testing

MDL-47812 LTI unit test fails on oracle.

has a non-specific relationship to

MDL-31625 Overfilling DB entries with a replace causes error

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Michael de Raadt, Simey Lameze