Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47874

Test Oracle support of REPLACE function

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.8
    • 2.8
    • Database SQL/XMLDB
    • MOODLE_28_STABLE
    • MOODLE_28_STABLE
    • Hide

      1) TEST: Verify that dml tests are passing under all DBs (vendor/bin/phpunit lib/dml/tests/dml_test.php) with zero skipped.
      2) In a Oracle installed site:

      • Add some content to be replaced here and there (some description, course name, a post...).
      • Go to the replace admin tool (admin/tool/replace/)
      • Search for the content you just introduced and replace it by another one.
      • Perform the search/replace (Yes, do it! button). Can be long, with debugging enabled you should see the SQL happening...
      • TEST: Verify that the contents have been properly replaced in the places you originally introduced them.
      Show
      1) TEST: Verify that dml tests are passing under all DBs (vendor/bin/phpunit lib/dml/tests/dml_test.php) with zero skipped. 2) In a Oracle installed site: Add some content to be replaced here and there (some description, course name, a post...). Go to the replace admin tool (admin/tool/replace/) Search for the content you just introduced and replace it by another one. Perform the search/replace (Yes, do it! button). Can be long, with debugging enabled you should see the SQL happening... TEST: Verify that the contents have been properly replaced in the places you originally introduced them.

    Description

      for some reason in MDL-31625 Oracle was left out as database not supporting REPLACE function but it does.

      Either:

      • Implement oci_native_moodle_database::replace_all_text_supported() to return true
      • Remove the function replace_all_text_supported() and all of it's usages (leave it in moodle_database as returning true)

      Make sure all unittests pass on oracle

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              marina Marina Glancy
              Simey Lameze Simey Lameze
              Dan Poltawski Dan Poltawski
              Michael de Raadt Michael de Raadt
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Nov/14