Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47874

Test Oracle support of REPLACE function

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Database SQL/XMLDB
    • Labels:
    • Testing Instructions:
      Hide

      1) TEST: Verify that dml tests are passing under all DBs (vendor/bin/phpunit lib/dml/tests/dml_test.php) with zero skipped.
      2) In a Oracle installed site:

      • Add some content to be replaced here and there (some description, course name, a post...).
      • Go to the replace admin tool (admin/tool/replace/)
      • Search for the content you just introduced and replace it by another one.
      • Perform the search/replace (Yes, do it! button). Can be long, with debugging enabled you should see the SQL happening...
      • TEST: Verify that the contents have been properly replaced in the places you originally introduced them.
      Show
      1) TEST: Verify that dml tests are passing under all DBs (vendor/bin/phpunit lib/dml/tests/dml_test.php) with zero skipped. 2) In a Oracle installed site: Add some content to be replaced here and there (some description, course name, a post...). Go to the replace admin tool (admin/tool/replace/) Search for the content you just introduced and replace it by another one. Perform the search/replace (Yes, do it! button). Can be long, with debugging enabled you should see the SQL happening... TEST: Verify that the contents have been properly replaced in the places you originally introduced them.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      for some reason in MDL-31625 Oracle was left out as database not supporting REPLACE function but it does.

      Either:

      • Implement oci_native_moodle_database::replace_all_text_supported() to return true
      • Remove the function replace_all_text_supported() and all of it's usages (leave it in moodle_database as returning true)

      Make sure all unittests pass on oracle

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Simey Lameze
              Integrator:
              Dan Poltawski
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14