[MDL-47902] Inappropriate default values for SCORM 1.3 variables - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.8
Fix Version/s: 2.8
Component/s: SCORM
Labels:
- SCORM_2004
- triaged

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
https://github.com/MorrisR2/moodle
Pull Main Branch:
~~MDL-47902~~_scorm_inappropriate_default_values
Pull Main Diff URL:
https://github.com/MorrisR2/moodle/compare/MDL-47902_scorm_inappropriate_default_values
Testing Instructions:
Hide

Add a SCORM (1.3) to a course. This simplest functional example SCORM package can be used:
http://scorm.com/wp-content/assets/golf_examples/PIFS/RuntimeMinimumCalls_SCORM20043rdEdition.zip

Set Activity completion for the activity to Require status: Completed.

Enter the activity.

Click "Exit activity" to leave the activity.

Confirm that the activity is NOT marked complete on the course home page.
NOTE: Moodle does NOT provide full SCORM 2004 support - there are many other potential issues that may occur while using this package - ignore anything unrelated to the specific test case.
Show
Add a SCORM (1.3) to a course. This simplest functional example SCORM package can be used: http://scorm.com/wp-content/assets/golf_examples/PIFS/RuntimeMinimumCalls_SCORM20043rdEdition.zip Set Activity completion for the activity to Require status: Completed. Enter the activity. Click "Exit activity" to leave the activity. Confirm that the activity is NOT marked complete on the course home page. NOTE: Moodle does NOT provide full SCORM 2004 support - there are many other potential issues that may occur while using this package - ignore anything unrelated to the specific test case.

Description

cmi scorm variables are set with incorrect default values, such as the string "null" being set for some numeric values in scorm 1.3. They should instead be done like scorm 1.2 - left unset.

Regression symptoms from this include activities incorrectly being marked complete as soon as they are viewed. This is because the test for completion is:

if ((cmi.completion_threshold != null) && (cmi.progress_measure != null))

Because each value is set to the string "null", they are not null, and the scorm is marked as complete.

Attachments

Issue Links

has a non-specific relationship to

MDL-46669 mod_scorm: GetValue adds quotes to string values, in 1.3 copy only

Closed

Activity

People

Assignee:: Ray Morris

Reporter:: Ray Morris

Peer reviewer:: Dan Marsden

Integrator:: Damyon Wiese

Tester:: David Monllaó

Participants:: Damyon Wiese, Dan Marsden, David Monllaó, Eloy Lafuente (stronk7), Ray Morris

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 28/Oct/14 6:54 AM

Updated:: 08/Nov/14 9:50 AM

Resolved:: 08/Nov/14 9:50 AM

Fix Release Date:: 10/Nov/14