[MDL-47915] Two inconsistent layout files should be consistent, use id=page-content rather than content - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.6.5, 2.7.2, 2.8
Fix Version/s: 2.7.4, 2.8.2, 2.9
Component/s: SCORM, Themes
Labels:
- ci
- triaged
- ui_change

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/lazydaisy/moodle.git
Pull Master Branch:
~~MDL-47915~~_master
Pull Master Diff URL:
https://github.com/lazydaisy/moodle/compare/master...MDL-47915_master
Testing Instructions:
Hide

Select Base theme.

Go to a course page and add a SCORM package, such as the "Basic Run-Time Calls" golf sample from SCORM.com.

Set the SCORM to display in a new window

Open the SCORM and advance at least one page.

Click the Exit button within the SCORM

When prompted, choose Ok to save your progress

Ensure that no errors are thrown. Specifically, this error should be fixed:
Uncaught TypeError: Cannot read property 'appendChild' of null
Display course structure on entry page Help with Display course structure on entry page

I apologize, I'm not sure which user-visible functionality is affected. I'll be out of the office for a while, so I probably won't track it down soon, but clearly a) there should not be errors thrown and b) consistent naming between themes and layouts is a good thing.
Show
Select Base theme. Go to a course page and add a SCORM package, such as the "Basic Run-Time Calls" golf sample from SCORM.com. Set the SCORM to display in a new window Open the SCORM and advance at least one page. Click the Exit button within the SCORM When prompted, choose Ok to save your progress Ensure that no errors are thrown. Specifically, this error should be fixed: Uncaught TypeError: Cannot read property 'appendChild' of null Display course structure on entry page Help with Display course structure on entry page I apologize, I'm not sure which user-visible functionality is affected. I'll be out of the office for a while, so I probably won't track it down soon, but clearly a) there should not be errors thrown and b) consistent naming between themes and layouts is a good thing.

Description

All of the layout files have a main content div, which is always called id="page-content", except in two of the embedded.php layouts. This creates a problem for mod_scorm, whose module.js has long used getElementById('page-content').

base/layout/embedded.php: <div id="content"
base/layout/frontpage.php: <div id="page-content">
base/layout/general.php: <div id="page-content">
base/layout/report.php: <div id="page-content"
bootstrapbase/layout/columns1.php: <div id="page-content"
bootstrapbase/layout/columns2.php: <div id="page-content"
bootstrapbase/layout/columns3.php: <div id="page-content"
bootstrapbase/layout/embedded.php: <div id="page-content"
bootstrapbase/layout/maintenance.php: <div id="page-content"
bootstrapbase/layout/popup.php: <div id="page-content"
bootstrapbase/layout/secure.php: <div id="page-content"
canvas/layout/embedded.php: <div id="content"
canvas/layout/frontpage.php: <div id="page-content">
canvas/layout/general.php: <div id="page-content">
canvas/layout/report.php: <div id="page-content">
clean/layout/columns1.php: <div id="page-content"
clean/layout/columns2.php: <div id="page-content"
clean/layout/columns3.php: <div id="page-content"
clean/layout/embedded.php: <div id="page-content"
clean/layout/maintenance.php: <div id="page-content"
clean/layout/secure.php: <div id="page-content"

Attachments

Activity

People

Assignee:: Mary Evans

Reporter:: Ray Morris

Peer reviewer:: Marina Glancy

Integrator:: Dan Poltawski

Tester:: Simey Lameze

Participants:: CiBoT, Dan Marsden, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Mary Evans, Ray Morris, Sam Hemelryk, Simey Lameze

Component watchers:: Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Huong Nguyen, Bas Brands, Mathew May

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 28/Oct/14 2:01 PM

Updated:: 07/Jan/15 10:38 PM

Resolved:: 21/Nov/14 9:11 AM

Fix Release Date:: 12/Jan/15